From: cel@kernel.org
To: NeilBrown <neil@brown.name>, Jeff Layton <jlayton@kernel.org>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: <linux-nfs@vger.kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v2 5/6] SUNRPC: Remove svc_fill_write_vector()
Date: Thu, 8 May 2025 13:37:39 -0400 [thread overview]
Message-ID: <20250508173740.5475-6-cel@kernel.org> (raw)
In-Reply-To: <20250508173740.5475-1-cel@kernel.org>
From: Chuck Lever <chuck.lever@oracle.com>
Clean up: This API is no longer used.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
include/linux/sunrpc/svc.h | 2 --
net/sunrpc/svc.c | 43 --------------------------------------
2 files changed, 45 deletions(-)
diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
index 088c162ae7d6..a1b48ad1d464 100644
--- a/include/linux/sunrpc/svc.h
+++ b/include/linux/sunrpc/svc.h
@@ -463,8 +463,6 @@ const char * svc_proc_name(const struct svc_rqst *rqstp);
int svc_encode_result_payload(struct svc_rqst *rqstp,
unsigned int offset,
unsigned int length);
-unsigned int svc_fill_write_vector(struct svc_rqst *rqstp,
- struct xdr_buf *payload);
char *svc_fill_symlink_pathname(struct svc_rqst *rqstp,
struct kvec *first, void *p,
size_t total);
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index d113f44798a1..c086f46265f6 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -1725,49 +1725,6 @@ int svc_encode_result_payload(struct svc_rqst *rqstp, unsigned int offset,
}
EXPORT_SYMBOL_GPL(svc_encode_result_payload);
-/**
- * svc_fill_write_vector - Construct data argument for VFS write call
- * @rqstp: RPC execution context
- * @payload: xdr_buf containing only the write data payload
- *
- * Fills in @rqstp->rq_bvec, and returns the number of elements it
- * populated in that array.
- */
-unsigned int svc_fill_write_vector(struct svc_rqst *rqstp,
- struct xdr_buf *payload)
-{
- struct page **pages = payload->pages;
- struct bio_vec *vec = rqstp->rq_bvec;
- struct kvec *first = payload->head;
- size_t total = payload->len;
- unsigned int base, len, i;
-
- /* Some types of transport can present the write payload
- * entirely in rq_arg.pages. In this case, @first is empty.
- */
- i = 0;
- if (first->iov_len) {
- len = min_t(size_t, total, first->iov_len);
- bvec_set_virt(&vec[i], first->iov_base, len);
- total -= len;
- ++i;
- }
-
- base = payload->page_base;
- while (total) {
- len = min_t(size_t, total, PAGE_SIZE);
- bvec_set_page(&vec[i], *pages, len, base);
- total -= len;
- base = 0;
- ++i;
- ++pages;
- }
-
- WARN_ON_ONCE(i > rqstp->rq_maxpages);
- return i;
-}
-EXPORT_SYMBOL_GPL(svc_fill_write_vector);
-
/**
* svc_fill_symlink_pathname - Construct pathname argument for VFS symlink call
* @rqstp: svc_rqst to operate on
--
2.49.0
next prev parent reply other threads:[~2025-05-08 17:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 17:37 [PATCH v2 0/6] Remove svc_rqst :: rq_vec cel
2025-05-08 17:37 ` [PATCH v2 1/6] NFSD: Use rqstp->rq_bvec in nfsd_iter_read() cel
2025-05-08 17:37 ` [PATCH v2 2/6] SUNRPC: Export xdr_buf_to_bvec() cel
2025-05-08 17:37 ` [PATCH v2 3/6] NFSD: De-duplicate the svc_fill_write_vector() call sites cel
2025-05-08 17:37 ` [PATCH v2 4/6] NFSD: Use rqstp->rq_bvec in nfsd_iter_write() cel
2025-05-08 17:37 ` cel [this message]
2025-05-08 17:37 ` [PATCH v2 6/6] SUNRPC: Remove svc_rqst :: rq_vec cel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250508173740.5475-6-cel@kernel.org \
--to=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox