[PATCH v2 5/6] SUNRPC: Remove svc_fill_write_vector()

cel
2025-05-08T17:37:46Z

Clean up: This API is no longer used.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
include/linux/sunrpc/svc.h | 2 --
net/sunrpc/svc.c | 43 --------------------------------------
2 files changed, 45 deletions(-)

diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
index 088c162ae7d6..a1b48ad1d464 100644
--- a/include/linux/sunrpc/svc.h
+++ b/include/linux/sunrpc/svc.h
@@ -463,8 +463,6 @@ const char * svc_proc_name(const struct svc_rqst *rqstp);
int svc_encode_result_payload(struct svc_rqst *rqstp,
unsigned int offset,
unsigned int length);
-unsigned int svc_fill_write_vector(struct svc_rqst *rqstp,
- struct xdr_buf *payload);
char *svc_fill_symlink_pathname(struct svc_rqst *rqstp,
struct kvec *first, void *p,
size_t total);
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index d113f44798a1..c086f46265f6 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -1725,49 +1725,6 @@ int svc_encode_result_payload(struct svc_rqst *rqstp, unsigned int offset,
}
EXPORT_SYMBOL_GPL(svc_encode_result_payload);

-/**
- * svc_fill_write_vector - Construct data argument for VFS write call
- * @rqstp: RPC execution context
- * @payload: xdr_buf containing only the write data payload
- *
- * Fills in @rqstp->rq_bvec, and returns the number of elements it
- * populated in that array.
- */
-unsigned int svc_fill_write_vector(struct svc_rqst *rqstp,
- struct xdr_buf *payload)
-{
- struct page **pages = payload->pages;
- struct bio_vec *vec = rqstp->rq_bvec;
- struct kvec *first = payload->head;
- size_t total = payload->len;
- unsigned int base, len, i;
-
- /* Some types of transport can present the write payload
- * entirely in rq_arg.pages. In this case, @first is empty.
- */
- i = 0;
- if (first->iov_len) {
- len = min_t(size_t, total, first->iov_len);
- bvec_set_virt(&vec[i], first->iov_base, len);
- total -= len;
- ++i;
- }
-
- base = payload->page_base;
- while (total) {
- len = min_t(size_t, total, PAGE_SIZE);
- bvec_set_page(&vec[i], *pages, len, base);
- total -= len;
- base = 0;
- ++i;
- ++pages;
- }
-
- WARN_ON_ONCE(i > rqstp->rq_maxpages);
- return i;
-}
-EXPORT_SYMBOL_GPL(svc_fill_write_vector);
-
/**
* svc_fill_symlink_pathname - Construct pathname argument for VFS symlink call
* @rqstp: svc_rqst to operate on
--
2.49.0