From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41EB713C8FF for ; Sun, 8 Jun 2025 22:08:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749420536; cv=none; b=rUAdqjGZDIsjQh+h/6Ebmnn/lnzxr9IDynjWxMrnIqgAnCzdYn/86oZ/byn58hDy/AaQrEOrv+gGClT7EeflIweGqbPJDV/sCt0PuUZeMw9jbLCgmETQGNnJ2S8u55NMblwX7S4Y0Kuk9bYc7KqdKcgY8ZzDFY2kjcI3rmCCNWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749420536; c=relaxed/simple; bh=vsZ+Qi8qCCvNTDx0hi14ye8/lXFEA2eH1F07ktmC8sg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cLN/O3NktSYKF4Dvl2mF6qvon9H7MoERbMXo+UHVC5nnfUm2lX5IceJbe5+/22A7pdyTf6ulW7hxKHlYrb5JWPDrcKwjQG8HgzLVIyLaL77iir8ERLPvUD8niqXUxAHYWhtvjyZt1rLlZQGTpl501o8N+oE0igcKSK0Pu/x53jU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W2IzDdPD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W2IzDdPD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3516AC4CEEE; Sun, 8 Jun 2025 22:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749420534; bh=vsZ+Qi8qCCvNTDx0hi14ye8/lXFEA2eH1F07ktmC8sg=; h=From:To:Cc:Subject:Date:From; b=W2IzDdPDNgEn4+caFZAAgTSyzxIFyqHnB9SP1gmobKXvJPO8O7m2BNSPCAfWqYVnT epuJES/v4KEaGuIWUhO+9XWwvfFl83rvGIZW6algdo0njIq4p/B0TvPFJCErE+6S7b jdqszOWBAA+/vSa2OsAiQ8CvdWhpSy0d6MZJR8eCmK9x4HN/YxaaqhxGmrSfige58m 9JiC7bXTZWJmw4lCJlm+BEbjUbBp5iOsK1BNCr73Kn0btruS3x7NcXo83I4nqkj4JG +safM8bAm0MSSxHVLIoyVE2zWrbLeCi9poXf81pwZ29coEvzwkOvciFkCAI02S0ysc hhF8vcHfMcHwg== From: Chuck Lever To: reviews Cc: , Chuck Lever , kernel test robot , Dan Carpenter Subject: [PATCH] NFSD: Avoid corruption of a referring call list Date: Sun, 8 Jun 2025 18:08:51 -0400 Message-ID: <20250608220851.2230459-1-cel@kernel.org> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chuck Lever The new code neglects to remove a freshly-allocated RCL from the callback's referring call list when no matching referring call is found. Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202505171002.cE46sdj5-lkp@intel.com/ Fixes: 4f3c8d8c9e10 ("NFSD: Implement CB_SEQUENCE referring call lists") Signed-off-by: Chuck Lever --- fs/nfsd/nfs4callback.c | 1 + 1 file changed, 1 insertion(+) I don't recall seeing this on the mailing list. Targeting this one for nfsd-fixes. diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c index ccb00aa93be0..e00b2aea8da2 100644 --- a/fs/nfsd/nfs4callback.c +++ b/fs/nfsd/nfs4callback.c @@ -1409,6 +1409,7 @@ void nfsd41_cb_referring_call(struct nfsd4_callback *cb, out: if (!rcl->__nr_referring_calls) { cb->cb_nr_referring_call_list--; + list_del(&rcl->__list); kfree(rcl); } } -- 2.49.0