Linux NFS development
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>, linux-nfs@vger.kernel.org
Cc: Chuck Lever <chuck.lever@oracle.com>,
	Trond Myklebust <trond.myklebust@hammerspace.com>,
	NeilBrown <neil@brown.name>, Jeff Layton <jlayton@kernel.org>
Subject: Unused trace events in nfs and nfsd
Date: Thu, 12 Jun 2025 21:58:01 -0400	[thread overview]
Message-ID: <20250612215801.2c4c0ff8@batman.local.home> (raw)

I have code that will trigger a warning if a trace event is defined but
not used[1]. It gives a list of unused events. Here's what I have in nfs
and nfsd:

warning: tracepoint 'nfs4_renew' is unused.
warning: tracepoint 'nfs4_rename' is unused.
warning: tracepoint 'nfsd_file_unhash_and_queue' is unused.
warning: tracepoint 'nfsd_file_lru_add_disposed' is unused.
warning: tracepoint 'nfsd_file_lru_del_disposed' is unused.
warning: tracepoint 'nfsd_file_gc_recent' is unused.
warning: tracepoint 'nfsd_ctl_maxconn' is unused.

nfs4_renew looks to never have been used.

trace_nfs4_rename() was removed by 33912be816d9 ("nfs: remove
synchronous rename code") but did not remove the event.

trace_nfsd_file_unhash_and_queue() was removed by ac3a2585f01 ("nfsd:
rework refcounting in filecache")

Events nfsd_file_lru_add_disposed and nfsd_file_lru_del_disposed were
added by 4a0e73e635e3 ("NFSD: Leave open files out of the filecache
LRU") but they were never used.

Event nfsd_file_gc_recent was added by 64912122a4f8 ("nfsd: filecache:
introduce NFSD_FILE_RECENT") but never used.

trace_nfsd_ctl_maxconn() was removed by a4b853f183a1 ("sunrpc: remove
all connection limit configuration") but did not remove the event.

-- Steve

[1] https://lore.kernel.org/linux-trace-kernel/20250612235827.011358765@goodmis.org/

             reply	other threads:[~2025-06-13  1:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-13  1:58 Steven Rostedt [this message]
2025-06-13 15:57 ` Unused trace events in nfs and nfsd Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250612215801.2c4c0ff8@batman.local.home \
    --to=rostedt@goodmis.org \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox