From: Christian Brauner <brauner@kernel.org>
To: Jeff Layton <jlayton@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>, Jan Kara <jack@suse.cz>,
Amir Goldstein <amir73il@gmail.com>,
Simona Vetter <simona@ffwll.ch>
Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
stable@kernel.org
Subject: [PATCH v2 01/11] fhandle: raise FILEID_IS_DIR in handle_type
Date: Tue, 24 Jun 2025 10:29:04 +0200 [thread overview]
Message-ID: <20250624-work-pidfs-fhandle-v2-1-d02a04858fe3@kernel.org> (raw)
In-Reply-To: <20250624-work-pidfs-fhandle-v2-0-d02a04858fe3@kernel.org>
Currently FILEID_IS_DIR is raised in fh_flags which is wrong.
Raise it in handle->handle_type were it's supposed to be.
Fixes: c374196b2b9f ("fs: name_to_handle_at() support for "explicit connectable" file handles")
Cc: <stable@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
---
fs/fhandle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fhandle.c b/fs/fhandle.c
index 3e092ae6d142..66ff60591d17 100644
--- a/fs/fhandle.c
+++ b/fs/fhandle.c
@@ -88,7 +88,7 @@ static long do_sys_name_to_handle(const struct path *path,
if (fh_flags & EXPORT_FH_CONNECTABLE) {
handle->handle_type |= FILEID_IS_CONNECTABLE;
if (d_is_dir(path->dentry))
- fh_flags |= FILEID_IS_DIR;
+ handle->handle_type |= FILEID_IS_DIR;
}
retval = 0;
}
--
2.47.2
next prev parent reply other threads:[~2025-06-24 8:29 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 8:29 [PATCH v2 00/11] fhandle, pidfs: allow open_by_handle_at() purely based on file handle Christian Brauner
2025-06-24 8:29 ` Christian Brauner [this message]
2025-06-24 9:31 ` [PATCH v2 01/11] fhandle: raise FILEID_IS_DIR in handle_type Jan Kara
2025-06-24 8:29 ` [PATCH v2 02/11] fhandle: hoist copy_from_user() above get_path_from_fd() Christian Brauner
2025-06-24 9:31 ` Jan Kara
2025-06-24 8:29 ` [PATCH v2 03/11] fhandle: rename to get_path_anchor() Christian Brauner
2025-06-24 9:31 ` Jan Kara
2025-06-24 8:29 ` [PATCH v2 04/11] pidfs: add pidfs_root_path() helper Christian Brauner
2025-06-24 9:31 ` Jan Kara
2025-06-24 8:29 ` [PATCH v2 05/11] fhandle: reflow get_path_anchor() Christian Brauner
2025-06-24 9:16 ` Jan Kara
2025-06-24 10:16 ` Christian Brauner
2025-06-24 8:29 ` [PATCH v2 06/11] uapi/fcntl: mark range as reserved Christian Brauner
2025-06-24 9:16 ` Jan Kara
2025-06-24 10:57 ` Amir Goldstein
2025-06-24 13:47 ` Christian Brauner
2025-06-24 8:29 ` [PATCH v2 07/11] uapi/fcntl: add FD_INVALID Christian Brauner
2025-06-24 9:17 ` Jan Kara
2025-06-24 8:29 ` [PATCH v2 08/11] exportfs: add FILEID_PIDFS Christian Brauner
2025-06-24 9:17 ` Jan Kara
2025-06-24 13:15 ` Amir Goldstein
2025-06-24 13:43 ` Christian Brauner
2025-06-24 14:20 ` Amir Goldstein
2025-06-24 8:29 ` [PATCH v2 09/11] fhandle: add EXPORT_OP_AUTONOMOUS_HANDLES marker Christian Brauner
2025-06-24 9:18 ` Jan Kara
2025-06-24 9:20 ` Jan Kara
2025-06-24 10:16 ` Christian Brauner
2025-06-24 8:29 ` [PATCH v2 10/11] fhandle, pidfs: support open_by_handle_at() purely based on file handle Christian Brauner
2025-06-24 9:30 ` Jan Kara
2025-06-24 10:15 ` Christian Brauner
2025-06-24 10:53 ` Amir Goldstein
2025-06-24 14:28 ` Amir Goldstein
2025-06-24 14:51 ` Christian Brauner
2025-06-24 15:07 ` Amir Goldstein
2025-06-24 15:23 ` Christian Brauner
2025-06-24 17:45 ` Jan Kara
2025-06-24 19:23 ` Amir Goldstein
2025-06-25 7:52 ` Christian Brauner
2025-06-24 23:07 ` Al Viro
2025-06-25 7:52 ` Christian Brauner
2025-06-24 8:29 ` [PATCH v2 11/11] selftests/pidfd: decode pidfd file handles withou having to specify an fd Christian Brauner
2025-06-24 9:39 ` Jan Kara
2025-06-24 10:58 ` [PATCH v2 00/11] fhandle, pidfs: allow open_by_handle_at() purely based on file handle Amir Goldstein
2025-06-24 10:59 ` Christian Brauner
2025-06-24 14:15 ` Jan Kara
2025-06-24 14:34 ` Amir Goldstein
2025-06-24 14:39 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250624-work-pidfs-fhandle-v2-1-d02a04858fe3@kernel.org \
--to=brauner@kernel.org \
--cc=amir73il@gmail.com \
--cc=chuck.lever@oracle.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox