Re: [PATCH v2 0/3] Fix localio hangs

NeilBrown
2025-07-16T22:09:15Z

On Thu, 17 Jul 2025, Trond Myklebust wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
>
> The following patch series fixes a series of issues with the current
> localio code, as reported in the link
> https://lore.kernel.org/linux-nfs/aG0pJXVtApZ9C5vy@kernel.org/
>
>
> Trond Myklebust (3):
> NFS/localio: nfs_close_local_fh() fix check for file closed
> NFS/localio: nfs_uuid_put() fix races with nfs_open/close_local_fh()
> NFS/localio: nfs_uuid_put() fix the wake up after unlinking the file

That all looks good to me - thanks a lot for finding and fixing my bugs.

Reviewed-by: NeilBrown <neil@brown.name>

I'd still like to fix the nfsd_file_cache_purge() issue but that is
quite separate especially now that you've prevented it causing problems
for nfs_uuid_put().

thanks,
NeilBrown

>
> fs/nfs_common/nfslocalio.c | 28 +++++++++++++++++-----------
> 1 file changed, 17 insertions(+), 11 deletions(-)
>
> --
> 2.50.1
>
>