From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9CCE2D1F40 for ; Tue, 26 Aug 2025 18:57:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756234643; cv=none; b=BamI4WGMlKFViXRCTNyNpBy+my96H7dLia/jnMmMxHEvNi1vVCD56LF6befAHHcia7msa91xMNViKH1xkEE7wfXguSToiBlvJD+nwDGEU7Pde5Lk4pbh5sFwbFzyCE2mnhD1sQns+fMj0Qei3EAEj1pztwAd5Tcu4ZmuKpbQFc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756234643; c=relaxed/simple; bh=XCjE3xs0PFWKkbu0hgQhVlyi3VvDxjoKluyo29O7+OU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AgVUxz6fd4U2l4jEstvbzfGDNEKbUeujkHzJyxH8DMMv7hbGdTV951r6iRlXuzPDo5jzJzyhNB6dnk4pLQlLqpEqZXypjbOmBhim+loHOoOO9jDMX3JfP8A8iGR0m+TdDSH2YUXMjkZ+pxXDt/rLxD3uxY/yEhRkhXB+DeFCDjg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ONkEn3oo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ONkEn3oo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC99AC113D0; Tue, 26 Aug 2025 18:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756234642; bh=XCjE3xs0PFWKkbu0hgQhVlyi3VvDxjoKluyo29O7+OU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ONkEn3ooWfVrckyreqAmYCgghezDMHDlTHScnawtgzaIc2X1P6V/GQcnbnHIei2st 288ralhdMK4S1VY2dsjOvgb1n0icQOqFa1Dze2OxbaDqX/vlRTgETDzmRhmY6Es8td 13Nk611UWSBczFLj2YXAgVy7MAXS6bCdzX62jnw6Cl22jbPWo9FVDRLfsLpUKf4sBk cae77ThBViGl0SY2qD7UlbmHAh1v6iG0/Tu2BDJigGKbsAEkdKJLvp+yvsN9tdeDbR xq/9jHKQL4+Q+a4rEADh4IxNNUNQn0LmWgm2rKxAzTrU6nwU9lBm/NSzzXBrRW117W JSsibz71870FQ== From: Mike Snitzer To: Chuck Lever , Jeff Layton Cc: linux-nfs@vger.kernel.org Subject: [PATCH v8 1/7] NFSD: filecache: add STATX_DIOALIGN and STATX_DIO_READ_ALIGN support Date: Tue, 26 Aug 2025 14:57:12 -0400 Message-ID: <20250826185718.5593-2-snitzer@kernel.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20250826185718.5593-1-snitzer@kernel.org> References: <20250826185718.5593-1-snitzer@kernel.org> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use STATX_DIOALIGN and STATX_DIO_READ_ALIGN to get and store DIO alignment attributes from underlying filesystem in associated nfsd_file. This is done when the nfsd_file is first opened for a regular file. Signed-off-by: Mike Snitzer Reviewed-by: Jeff Layton --- fs/nfsd/filecache.c | 32 ++++++++++++++++++++++++++++++++ fs/nfsd/filecache.h | 4 ++++ fs/nfsd/nfsfh.c | 4 ++++ 3 files changed, 40 insertions(+) diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c index 8581c131338b8..5447dba6c5da0 100644 --- a/fs/nfsd/filecache.c +++ b/fs/nfsd/filecache.c @@ -231,6 +231,9 @@ nfsd_file_alloc(struct net *net, struct inode *inode, unsigned char need, refcount_set(&nf->nf_ref, 1); nf->nf_may = need; nf->nf_mark = NULL; + nf->nf_dio_mem_align = 0; + nf->nf_dio_offset_align = 0; + nf->nf_dio_read_offset_align = 0; return nf; } @@ -1048,6 +1051,33 @@ nfsd_file_is_cached(struct inode *inode) return ret; } +static __be32 +nfsd_file_getattr(const struct svc_fh *fhp, struct nfsd_file *nf) +{ + struct inode *inode = file_inode(nf->nf_file); + struct kstat stat; + __be32 status; + + /* Currently only need to get DIO alignment info for regular files */ + if (!S_ISREG(inode->i_mode)) + return nfs_ok; + + status = fh_getattr(fhp, &stat); + if (status != nfs_ok) + return status; + + if (stat.result_mask & STATX_DIOALIGN) { + nf->nf_dio_mem_align = stat.dio_mem_align; + nf->nf_dio_offset_align = stat.dio_offset_align; + } + if (stat.result_mask & STATX_DIO_READ_ALIGN) + nf->nf_dio_read_offset_align = stat.dio_read_offset_align; + else + nf->nf_dio_read_offset_align = nf->nf_dio_offset_align; + + return status; +} + static __be32 nfsd_file_do_acquire(struct svc_rqst *rqstp, struct net *net, struct svc_cred *cred, @@ -1166,6 +1196,8 @@ nfsd_file_do_acquire(struct svc_rqst *rqstp, struct net *net, } status = nfserrno(ret); trace_nfsd_file_open(nf, status); + if (status == nfs_ok) + status = nfsd_file_getattr(fhp, nf); } } else status = nfserr_jukebox; diff --git a/fs/nfsd/filecache.h b/fs/nfsd/filecache.h index 24ddf60e8434a..e3d6ca2b60308 100644 --- a/fs/nfsd/filecache.h +++ b/fs/nfsd/filecache.h @@ -54,6 +54,10 @@ struct nfsd_file { struct list_head nf_gc; struct rcu_head nf_rcu; ktime_t nf_birthtime; + + u32 nf_dio_mem_align; + u32 nf_dio_offset_align; + u32 nf_dio_read_offset_align; }; int nfsd_file_cache_init(void); diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c index f4a3cc9e31e05..bdba2ba828a6a 100644 --- a/fs/nfsd/nfsfh.c +++ b/fs/nfsd/nfsfh.c @@ -677,8 +677,12 @@ __be32 fh_getattr(const struct svc_fh *fhp, struct kstat *stat) .mnt = fhp->fh_export->ex_path.mnt, .dentry = fhp->fh_dentry, }; + struct inode *inode = d_inode(p.dentry); u32 request_mask = STATX_BASIC_STATS; + if (S_ISREG(inode->i_mode)) + request_mask |= (STATX_DIOALIGN | STATX_DIO_READ_ALIGN); + if (fhp->fh_maxsize == NFS4_FHSIZE) request_mask |= (STATX_BTIME | STATX_CHANGE_COOKIE); -- 2.44.0