Linux NFS development
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@kernel.org>
To: Chuck Lever <chuck.lever@oracle.com>, Jeff Layton <jlayton@kernel.org>
Cc: NeilBrown <neil@brown.name>,
	Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
	linux-nfs@vger.kernel.org
Subject: [PATCH 0/2] NFSD: continuation of NFSD DIRECT
Date: Tue,  9 Sep 2025 19:33:13 -0400	[thread overview]
Message-ID: <20250909233315.80318-1-snitzer@kernel.org> (raw)
In-Reply-To: <20250909190525.7214-1-cel@kernel.org>

Hi Chuck,

These patches build ontop of your recent series, here:
https://lore.kernel.org/linux-nfs/20250909190525.7214-1-cel@kernel.org/

The first sunrpc patch is carry-over from earlier iterations of my
NFSD DIRECT patchsets. I think it needed to be sure we have adequate
pages to handle expanding misaligned READ to fit in max payload. But
maybe not?

The 2nd "NFSD: Implement NFSD_IO_DIRECT for NFS WRITE" patch is a
refactored version of my earlier NFS WRITE support.  I tried to honor
the types of changes I saw in your rewrite of the NFSD_IO_DIRECT NFS
READ support. So I avoided needless maths and variables that were only
for the benefit of excessive tracepoint complexity (which I also
removed), while also establishing cleaner code that you can iterate on
further if you think something else needed. LOC isn't much smaller
but maybe you or others will see something that can be elided -- the
good news is this NFSD DIRECT WRITE code stands on its own like the
NFSD DIRECT READ does.

Not sure what NFSD DIRECT WRITE gray areas you think we need to work
through further in NFSD (but I could imagine there being room for
common Linux vfs code or other FS-specific code improvements to make
buffered vs direct safer). I know others have repeated concern but in
practice I haven't had any issues with this NFSD DIRECT WRITE
suppoort. So I welcome further discussion on what else needed.

Thanks,
Mike

Mike Snitzer (2):
  sunrpc: add an extra reserve page to svc_serv_maxpages()
  NFSD: Implement NFSD_IO_DIRECT for NFS WRITE

 fs/nfsd/debugfs.c          |   1 +
 fs/nfsd/trace.h            |   1 +
 fs/nfsd/vfs.c              | 215 ++++++++++++++++++++++++++++++++++++-
 include/linux/sunrpc/svc.h |   5 +-
 4 files changed, 216 insertions(+), 6 deletions(-)

-- 
2.44.0


  parent reply	other threads:[~2025-09-09 23:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09 19:05 [PATCH v1 0/3] NFSD direct I/O read Chuck Lever
2025-09-09 19:05 ` [PATCH v1 1/3] NFSD: filecache: add STATX_DIOALIGN and STATX_DIO_READ_ALIGN support Chuck Lever
2025-09-09 23:07   ` NeilBrown
2025-09-09 19:05 ` [PATCH v1 2/3] NFSD: pass nfsd_file to nfsd_iter_read() Chuck Lever
2025-09-09 23:20   ` NeilBrown
2025-09-09 19:05 ` [PATCH v1 3/3] NFSD: Implement NFSD_IO_DIRECT for NFS READ Chuck Lever
2025-09-09 23:16   ` Mike Snitzer
2025-09-09 23:37   ` NeilBrown
2025-09-09 23:39     ` Chuck Lever
2025-09-09 23:48       ` Chuck Lever
2025-09-10  1:54         ` NeilBrown
2025-09-10  1:52       ` NeilBrown
2025-09-10 14:23         ` Chuck Lever
2025-09-09 23:56     ` Mike Snitzer
2025-09-10 11:37   ` Jeff Layton
2025-09-09 23:33 ` Mike Snitzer [this message]
2025-09-09 23:33   ` [PATCH 1/2] sunrpc: add an extra reserve page to svc_serv_maxpages() Mike Snitzer
2025-09-10 14:29     ` Chuck Lever
2025-09-09 23:33   ` [PATCH 2/2] NFSD: Implement NFSD_IO_DIRECT for NFS WRITE Mike Snitzer
2025-10-08 18:59     ` [PATCH v2] " Mike Snitzer
2025-10-09 15:04       ` Jeff Layton
2025-10-09 17:46       ` Chuck Lever
2025-10-13 15:41         ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250909233315.80318-1-snitzer@kernel.org \
    --to=snitzer@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=dai.ngo@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox