From: Chuck Lever <cel@kernel.org>
To: NeilBrown <neil@brown.name>, Jeff Layton <jlayton@kernel.org>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: <linux-nfs@vger.kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v1 0/2] Fix unwanted memory overwrites
Date: Mon, 6 Oct 2025 14:45:00 -0400 [thread overview]
Message-ID: <20251006184502.1414-1-cel@kernel.org> (raw)
From: Chuck Lever <chuck.lever@oracle.com>
<rtm@csail.mit.edu> reported some memory overwrites that can be
triggered by NFS client input. I was able to observe overwrites
by enabling KASAN and running his reproducer [1].
NFSD caches COMPOUNDs containing only a single SEQUENCE operation
whether the client requests it to or not, in order to work around a
deficiency in the NFSv4.1 protocol. However, the predicate that
identifies solo SEQUENCE operations was incorrect.
(Based on my reading of RFC 8881, I'm not sure NFSD should cache
solo SEQUENCE operations that fail, but that is perhaps for a
different day).
Chuck Lever (2):
NFSD: Do not cache failed SEQUENCE operations
NFSD: Skip close replay processing if XDR encoding fails
fs/nfsd/nfs4xdr.c | 3 +--
fs/nfsd/xdr4.h | 3 ++-
2 files changed, 3 insertions(+), 3 deletions(-)
--
2.51.0
[1] http://www.rtmrtm.org/rtm/nfsd185f.c
next reply other threads:[~2025-10-06 18:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 18:45 Chuck Lever [this message]
2025-10-06 18:45 ` [PATCH v1 1/2] NFSD: Do not cache failed SEQUENCE operations Chuck Lever
2025-10-06 18:45 ` [PATCH v1 2/2] NFSD: Skip close replay processing if XDR encoding fails Chuck Lever
2025-10-07 14:18 ` Jeff Layton
2025-10-07 14:24 ` Chuck Lever
2025-10-07 12:45 ` [PATCH v1 0/2] Fix unwanted memory overwrites Tom Talpey
2025-10-07 13:16 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251006184502.1414-1-cel@kernel.org \
--to=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).