From: Christian Brauner <brauner@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <christian@brauner.io>,
Marc Dionne <marc.dionne@auristor.com>,
Jeffrey Altman <jaltman@auristor.com>,
Steve French <sfrench@samba.org>,
linux-afs@lists.infradead.org, openafs-devel@openafs.org,
linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Etienne Champetier <champetier.etienne@gmail.com>,
Chet Ramey <chet.ramey@case.edu>,
Cheyenne Wills <cwills@sinenomine.net>,
Mimi Zohar <zohar@linux.ibm.com>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH 1/2] vfs: Allow filesystems with foreign owner IDs to override UID checks
Date: Wed, 29 Oct 2025 13:39:45 +0100 [thread overview]
Message-ID: <20251029-brust-reden-b61f1a55dc3b@brauner> (raw)
In-Reply-To: <1523597.1761052821@warthog.procyon.org.uk>
On Tue, Oct 21, 2025 at 02:20:21PM +0100, David Howells wrote:
> Christian Brauner <brauner@kernel.org> wrote:
>
> > > + if (unlikely(inode->i_op->have_same_owner)) {
> >
> > Same, as above: similar to IOP_FASTPERM this should use a flag to avoid pointer derefs.
>
> Can we do these IOP_* flags better? Surely we can determine at the point the
> inode has its ->i_op assigned that these things are provided? This optimises
> the case where they don't exist at the expense of the case where they do (we
> still have to check the pointer every time).
>
> > > + if (unlikely(inode->i_op->have_same_owner)) {
I think I mentioned this off-list. It looks like we can but I don't know
if there was any history behind not doing it that way. But please try.
next prev parent reply other threads:[~2025-10-29 12:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 13:35 [PATCH 0/2] vfs, afs, bash: Fix miscomparison of foreign user IDs in the VFS David Howells
2025-10-14 13:35 ` [PATCH 1/2] vfs: Allow filesystems with foreign owner IDs to override UID checks David Howells
2025-10-21 12:38 ` Christian Brauner
2025-10-21 13:20 ` David Howells
2025-10-29 12:39 ` Christian Brauner [this message]
2025-10-14 13:35 ` [PATCH 2/2] afs, bash: Fix open(O_CREAT) on an extant AFS file in a sticky dir David Howells
2025-10-14 18:27 ` [PATCH 0/2] vfs, afs, bash: Fix miscomparison of foreign user IDs in the VFS Steve French
-- strict thread matches above, loose matches on Subject: below --
2025-09-03 12:01 David Howells
2025-09-03 12:01 ` [PATCH 1/2] vfs: Allow filesystems with foreign owner IDs to override UID checks David Howells
2025-07-23 15:26 [PATCH 0/2] vfs, afs, bash: Fix miscomparison of foreign user IDs in the VFS David Howells
2025-07-23 15:26 ` [PATCH 1/2] vfs: Allow filesystems with foreign owner IDs to override UID checks David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029-brust-reden-b61f1a55dc3b@brauner \
--to=brauner@kernel.org \
--cc=champetier.etienne@gmail.com \
--cc=chet.ramey@case.edu \
--cc=christian@brauner.io \
--cc=cwills@sinenomine.net \
--cc=dhowells@redhat.com \
--cc=jaltman@auristor.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=openafs-devel@openafs.org \
--cc=sfrench@samba.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox