From: Christoph Hellwig <hch@lst.de>
To: Dai Ngo <dai.ngo@oracle.com>
Cc: chuck.lever@oracle.com, jlayton@kernel.org, neilb@ownmail.net,
okorniev@redhat.com, tom@talpey.com, hch@lst.de,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH 2/3] NFSD: Do not fence the client on NFS4ERR_RETRY_UNCACHED_REP error
Date: Mon, 3 Nov 2025 12:45:00 +0100 [thread overview]
Message-ID: <20251103114500.GC14852@lst.de> (raw)
In-Reply-To: <20251101185220.663905-3-dai.ngo@oracle.com>
On Sat, Nov 01, 2025 at 11:51:34AM -0700, Dai Ngo wrote:
> NFS4ERR_RETRY_UNCACHED_REP error means client has seen and replied
> to the layout recall, no fencing is needed.
RFC 5661 specifies that error as:
The requester has attempted a retry of a Compound that it previously
requested not be placed in the reply cache.
which to me doesn't imply a positive action here. But I'm not an
expert at reply cache semantics, so I'll leave others to correct me.
But please add a more detailed comment and commit log as this is
completely unintuitive.
next prev parent reply other threads:[~2025-11-03 11:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-01 18:51 [PATCH 0/3] NFSD: Fix problem with nfsd4_scsi_fence_client Dai Ngo
2025-11-01 18:51 ` [PATCH 1/3] NFSD: Fix problem with nfsd4_scsi_fence_client using the wrong reservation type Dai Ngo
2025-11-03 11:42 ` Christoph Hellwig
2025-11-01 18:51 ` [PATCH 2/3] NFSD: Do not fence the client on NFS4ERR_RETRY_UNCACHED_REP error Dai Ngo
2025-11-03 11:45 ` Christoph Hellwig [this message]
2025-11-03 14:16 ` Chuck Lever
2025-11-03 18:50 ` Dai Ngo
2025-11-03 18:57 ` Chuck Lever
2025-11-03 19:14 ` Dai Ngo
2025-11-03 20:03 ` Dai Ngo
2025-11-03 20:15 ` Chuck Lever
2025-11-03 20:36 ` Dai Ngo
2025-11-03 19:22 ` Jeff Layton
2025-11-03 19:36 ` Dai Ngo
2025-11-03 19:40 ` Jeff Layton
2025-11-01 18:51 ` [PATCH 3/3] NFSD: Add trace point for SCSI fencing operation Dai Ngo
2025-11-02 15:40 ` Chuck Lever
2025-11-03 20:44 ` Dai Ngo
2025-11-03 21:00 ` Chuck Lever
2025-11-04 0:32 ` Dai Ngo
2025-11-04 14:05 ` Chuck Lever
-- strict thread matches above, loose matches on Subject: below --
2025-11-01 18:25 Dai Ngo
2025-11-01 18:25 ` [PATCH 2/3] NFSD: Do not fence the client on NFS4ERR_RETRY_UNCACHED_REP error Dai Ngo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103114500.GC14852@lst.de \
--to=hch@lst.de \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@ownmail.net \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).