From: Greg KH <gregkh@linuxfoundation.org>
To: Trond Myklebust <trondmy@kernel.org>
Cc: stable@vger.kernel.org, Mike Snitzer <snitzer@kernel.org>,
Zorro Lang <zlang@redhat.com>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfs/localio: fix regression due to out-of-order __put_cred
Date: Sun, 7 Dec 2025 09:42:37 +0900 [thread overview]
Message-ID: <2025120753-cycling-shifty-4967@gregkh> (raw)
In-Reply-To: <30a4385509b4daa55512058c02685314adda85d7.1765066510.git.trond.myklebust@hammerspace.com>
On Sat, Dec 06, 2025 at 07:24:14PM -0500, Trond Myklebust wrote:
> From: Mike Snitzer <snitzer@kernel.org>
>
> commit 3af870aedbff10bfed220e280b57a405e972229f upstream.
>
> Commit f2060bdc21d7 ("nfs/localio: add refcounting for each iocb IO
> associated with NFS pgio header") inadvertantly reintroduced the same
> potential for __put_cred() triggering BUG_ON(cred == current->cred)
> that commit 992203a1fba5 ("nfs/localio: restore creds before releasing
> pageio data") fixed.
>
> Fix this by saving and restoring the cred around each {read,write}_iter
> call within the respective for loop of nfs_local_call_{read,write}.
>
> Reported-by: Zorro Lang <zlang@redhat.com>
> Fixes: f2060bdc21d7 ("nfs/localio: add refcounting for each iocb IO associated with NFS pgio header")
> Cc: <stable@vger.kernel.org> # 6.18.x
> Signed-off-by: Mike Snitzer <snitzer@kernel.org>
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
What kernel is this for, just 6.18.y? And why was the changelog
rewritten/formatted from the original?
thanks,
greg k-h
next prev parent reply other threads:[~2025-12-07 0:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-07 0:24 [PATCH] nfs/localio: fix regression due to out-of-order __put_cred Trond Myklebust
2025-12-07 0:42 ` Greg KH [this message]
2025-12-07 5:23 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025120753-cycling-shifty-4967@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-nfs@vger.kernel.org \
--cc=snitzer@kernel.org \
--cc=stable@vger.kernel.org \
--cc=trondmy@kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox