From: Chuck Lever <cel@kernel.org>
To: NeilBrown <neilb@ownmail.net>, Jeff Layton <jlayton@kernel.org>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: <linux-nfs@vger.kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v2 0/2] nfsd: fix handling of timed out idmap lookups
Date: Mon, 22 Dec 2025 14:30:03 -0500 [thread overview]
Message-ID: <20251222193005.1492196-1-cel@kernel.org> (raw)
From: Chuck Lever <chuck.lever@oracle.com>
Following up on:
https://lore.kernel.org/linux-nfs/20251127175753.134132-1-ailiop@suse.com/#r
This series addresses an issue occurring during v4 compound decoding, when
idmap lookup upcall responses are delayed in userspace. This causes the
related request to be marked for deferral and to be dropped, preventing
nfs4svc_encode_compoundres from being executed and thus never clearing the
session slot flag NFSD4_SLOT_INUSE. Subsequent requests will fail with
NFSERR_JUKEBOX, given that the slot will be marked as in use.
The first patch fixes this by making sure that no deferrals can happen
during decoding.
The second patch fixes the return code of delayed idmap lookups, so that
clients will retry the operation instead of aborting with an error.
Changes since v1:
- Address review comments
- Add Cc: stable tag
Anthony Iliopoulos (2):
nfsd: never defer requests during idmap lookup
nfsd: fix return error code for nfsd_map_name_to_[ug]id
fs/nfsd/nfs4idmap.c | 52 +++++++++++++++++++++++++++++++++++++++------
fs/nfsd/nfs4proc.c | 2 --
fs/nfsd/nfs4xdr.c | 16 ++++++++++++++
3 files changed, 62 insertions(+), 8 deletions(-)
--
2.52.0
next reply other threads:[~2025-12-22 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 19:30 Chuck Lever [this message]
2025-12-22 19:30 ` [PATCH v2 1/2] nfsd: never defer requests during idmap lookup Chuck Lever
2025-12-22 19:30 ` [PATCH v2 2/2] nfsd: fix return error code for nfsd_map_name_to_[ug]id Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251222193005.1492196-1-cel@kernel.org \
--to=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@ownmail.net \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).