Re: [PATCH v1 6/7] Set SB_POSIXACL if the server supports the extension

[kernel test robot <lkp@intel.com>]

Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on trondmy-nfs/linux-next]
[also build test ERROR on v6.16-rc1 next-20251219]
[cannot apply to linus/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/rick-macklem-gmail-com/Add-entries-to-the-predefined-client-operations-enum/20260103-073239
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
patch link:    https://lore.kernel.org/r/20260102232934.1560-7-rick.macklem%40gmail.com
patch subject: [PATCH v1 6/7] Set SB_POSIXACL if the server supports the extension
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260103/202601031746.QiLqxADW-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260103/202601031746.QiLqxADW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601031746.QiLqxADW-lkp@intel.com/

All errors (new ones prefixed by >>):

>> fs/nfs/super.c:1356:33: error: use of undeclared identifier 'FATTR4_WORD2_POSIX_DEFAULT_ACL'
    1356 |         if ((server->attr_bitmask[2] & FATTR4_WORD2_POSIX_DEFAULT_ACL) &&
         |                                        ^
>> fs/nfs/super.c:1357:33: error: use of undeclared identifier 'FATTR4_WORD2_POSIX_ACCESS_ACL'
    1357 |             (server->attr_bitmask[2] & FATTR4_WORD2_POSIX_ACCESS_ACL))
         |                                        ^
   2 errors generated.


vim +/FATTR4_WORD2_POSIX_DEFAULT_ACL +1356 fs/nfs/super.c

  1299	
  1300	int nfs_get_tree_common(struct fs_context *fc)
  1301	{
  1302		struct nfs_fs_context *ctx = nfs_fc2context(fc);
  1303		struct super_block *s;
  1304		int (*compare_super)(struct super_block *, struct fs_context *) = nfs_compare_super;
  1305		struct nfs_server *server = ctx->server;
  1306		int error;
  1307	
  1308		ctx->server = NULL;
  1309		if (IS_ERR(server))
  1310			return PTR_ERR(server);
  1311	
  1312		if (server->flags & NFS_MOUNT_UNSHARED)
  1313			compare_super = NULL;
  1314	
  1315		/* -o noac implies -o sync */
  1316		if (server->flags & NFS_MOUNT_NOAC)
  1317			fc->sb_flags |= SB_SYNCHRONOUS;
  1318	
  1319		/* Get a superblock - note that we may end up sharing one that already exists */
  1320		fc->s_fs_info = server;
  1321		s = sget_fc(fc, compare_super, nfs_set_super);
  1322		fc->s_fs_info = NULL;
  1323		if (IS_ERR(s)) {
  1324			error = PTR_ERR(s);
  1325			nfs_errorf(fc, "NFS: Couldn't get superblock");
  1326			goto out_err_nosb;
  1327		}
  1328	
  1329		if (s->s_fs_info != server) {
  1330			nfs_free_server(server);
  1331			server = NULL;
  1332		} else {
  1333			error = super_setup_bdi_name(s, "%u:%u", MAJOR(server->s_dev),
  1334						     MINOR(server->s_dev));
  1335			if (error)
  1336				goto error_splat_super;
  1337			s->s_bdi->io_pages = server->rpages;
  1338			server->super = s;
  1339		}
  1340	
  1341		if (!s->s_root) {
  1342			/* initial superblock/root creation */
  1343			nfs_fill_super(s, ctx);
  1344			error = nfs_get_cache_cookie(s, ctx);
  1345			if (error < 0)
  1346				goto error_splat_super;
  1347		}
  1348	
  1349		error = nfs_get_root(s, fc);
  1350		if (error < 0) {
  1351			nfs_errorf(fc, "NFS: Couldn't get root dentry");
  1352			goto error_splat_super;
  1353		}
  1354	
  1355		/* Set SB_POSIXACL if the server supports the NFSv4.2 extension. */
> 1356		if ((server->attr_bitmask[2] & FATTR4_WORD2_POSIX_DEFAULT_ACL) &&
> 1357		    (server->attr_bitmask[2] & FATTR4_WORD2_POSIX_ACCESS_ACL))
  1358			s->s_flags |= SB_POSIXACL;
  1359	
  1360		s->s_flags |= SB_ACTIVE;
  1361		error = 0;
  1362	
  1363	out:
  1364		return error;
  1365	
  1366	out_err_nosb:
  1367		nfs_free_server(server);
  1368		goto out;
  1369	error_splat_super:
  1370		deactivate_locked_super(s);
  1371		goto out;
  1372	}
  1373	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki