From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D79D93644B6 for ; Fri, 9 Jan 2026 16:21:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767975712; cv=none; b=fprFLXcgTe4dT3PTtqHx8RRfJn0/2htTVwaP0DelIOKN9xNXzEr8ys7aEfvzdvBJxfujShtpISQFcDjbYYEFNFuahEhQ3tMkaogzwuHBvJiCbVJK/kvM8K8QGNKixVqyVX0oNJRfH1V7SlgyseAfO6rvTsGuebBcyjO6G9rXZxI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767975712; c=relaxed/simple; bh=noZYdfeYdlY2Um7WmtUvt3PBqmkqKCKFBu1/CLFuRn8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qFhEypO1GQ0Aad4kKYQEsOPfq6gDNK1xsolKKF6QbFLD/C2nQhq+xeeSNxtLr+ASex1eOSrv++GP/rUE+REtksXIFhkYR6y+hHcPuXAfi1q9t3LKbYC+HqkwbZZ6BTJlRKmgDk3Dcvwonv0OA7qgUN2wOd6n4zd2lItvj+YEyPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h7DGlbWL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h7DGlbWL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9315C4CEF1; Fri, 9 Jan 2026 16:21:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767975712; bh=noZYdfeYdlY2Um7WmtUvt3PBqmkqKCKFBu1/CLFuRn8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h7DGlbWLPnsTd+QClBrKQJSjKuXAXXgxZcjGYex8nNhtfTeuWZbFHQNzPz4KDW/dy tjbiGdXDCoGCNvmssJIKPslxrR8MPt4aTpLArtAqaO8Ug14CUHmWILtfuKlcWMHk9P ZvEjOtoihKOIEf9Iu9roPh385oGh33PWQonpU4qfTyXCMMZ16rc/khtGKT0IOIM18c ZWJSaw7TwxwbZucyvmzjSbvxt5fBnPxil/cBqIAYgiAZRXuz2CxhTUCHtpG4ZVVPbu nOLv2YsveYPuFyEzkZy6nz2BtXK2wAgt66LFbot7W/atDYqWJqx0UmoC6CbEoy58t2 z9iEPHVx5mTdQ== From: Chuck Lever To: NeilBrown , Jeff Layton , Olga Kornievskaia , Dai Ngo , Tom Talpey Cc: , Rick Macklem Subject: [PATCH v3 04/13] NFSD: Add nfsd4_encode_fattr4_acl_trueform Date: Fri, 9 Jan 2026 11:21:33 -0500 Message-ID: <20260109162143.4186112-5-cel@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260109162143.4186112-1-cel@kernel.org> References: <20260109162143.4186112-1-cel@kernel.org> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Rick Macklem Mapping between NFSv4 ACLs and POSIX ACLs is semantically imprecise: a client that sets an NFSv4 ACL and reads it back may see a different ACL than it wrote. The proposed NFSv4 POSIX ACL extension introduces the FATTR4_ACL_TRUEFORM attribute, which reports whether a file object stores its access control permissions using NFSv4 ACLs or POSIX ACLs. A client aware of this extension can avoid lossy translation by requesting and setting ACLs in their native format. When NFSD is built with CONFIG_NFSD_V4_POSIX_ACLS, report ACL_MODEL_POSIX_DRAFT for file objects on file systems with the SB_POSIXACL flag set, and ACL_MODEL_NONE otherwise. Linux file systems do not store NFSv4 ACLs natively, so ACL_MODEL_NFS4 is never reported. Signed-off-by: Rick Macklem Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever --- fs/nfsd/nfs4xdr.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c index 5065727204b9..9b47cf17ddde 100644 --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c @@ -3470,6 +3470,22 @@ static __be32 nfsd4_encode_fattr4_open_arguments(struct xdr_stream *xdr, return nfs_ok; } +#ifdef CONFIG_NFSD_V4_POSIX_ACLS + +static __be32 nfsd4_encode_fattr4_acl_trueform(struct xdr_stream *xdr, + const struct nfsd4_fattr_args *args) +{ + aclmodel4 trueform = ACL_MODEL_NONE; + + if (IS_POSIXACL(d_inode(args->dentry))) + trueform = ACL_MODEL_POSIX_DRAFT; + if (!xdrgen_encode_aclmodel4(xdr, trueform)) + return nfserr_resource; + return nfs_ok; +} + +#endif /* CONFIG_NFSD_V4_POSIX_ACLS */ + static const nfsd4_enc_attr nfsd4_enc_fattr4_encode_ops[] = { [FATTR4_SUPPORTED_ATTRS] = nfsd4_encode_fattr4_supported_attrs, [FATTR4_TYPE] = nfsd4_encode_fattr4_type, @@ -3573,6 +3589,16 @@ static const nfsd4_enc_attr nfsd4_enc_fattr4_encode_ops[] = { [FATTR4_TIME_DELEG_ACCESS] = nfsd4_encode_fattr4__inval, [FATTR4_TIME_DELEG_MODIFY] = nfsd4_encode_fattr4__inval, [FATTR4_OPEN_ARGUMENTS] = nfsd4_encode_fattr4_open_arguments, + + /* Reserved */ + [87] = nfsd4_encode_fattr4__inval, + [88] = nfsd4_encode_fattr4__inval, + +#ifdef CONFIG_NFSD_V4_POSIX_ACLS + [FATTR4_ACL_TRUEFORM] = nfsd4_encode_fattr4_acl_trueform, +#else + [FATTR4_ACL_TRUEFORM] = nfsd4_encode_fattr4__noop, +#endif }; /* -- 2.52.0