Re: [PATCH v2 10/42] lockd: Move xdr.h from include/linux/lockd/ to fs/lockd/

[kernel test robot <lkp@intel.com>]

Hi Chuck,

kernel test robot noticed the following build errors:

[auto build test ERROR on trondmy-nfs/linux-next]
[also build test ERROR on brauner-vfs/vfs.all linus/master v6.19-rc6 next-20260123]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chuck-Lever/lockd-Simplify-cast_status-in-svcproc-c/20260124-025646
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
patch link:    https://lore.kernel.org/r/20260123185259.1215767-11-cel%40kernel.org
patch subject: [PATCH v2 10/42] lockd: Move xdr.h from include/linux/lockd/ to fs/lockd/
config: hexagon-defconfig (https://download.01.org/0day-ci/archive/20260124/202601241020.YgD8ze9Q-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9b8addffa70cee5b2acc5454712d9cf78ce45710)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260124/202601241020.YgD8ze9Q-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601241020.YgD8ze9Q-lkp@intel.com/

All errors (new ones prefixed by >>):

>> fs/nfs/nfs3proc.c:1009:8: error: incomplete definition of type 'struct file_lock'
    1009 |         if (fl->c.flc_flags & FL_CLOSE) {
         |             ~~^
   include/linux/fs.h:1332:8: note: forward declaration of 'struct file_lock'
    1332 | struct file_lock;
         |        ^
>> fs/nfs/nfs3proc.c:1009:24: error: use of undeclared identifier 'FL_CLOSE'; did you mean 'OP_CLOSE'?
    1009 |         if (fl->c.flc_flags & FL_CLOSE) {
         |                               ^~~~~~~~
         |                               OP_CLOSE
   include/linux/nfs4.h:83:2: note: 'OP_CLOSE' declared here
      83 |         OP_CLOSE = 4,
         |         ^
   2 errors generated.


vim +1009 fs/nfs/nfs3proc.c

f30cb757f680f96 Benjamin Coddington 2017-04-11  1000  
^1da177e4c3f415 Linus Torvalds      2005-04-16  1001  static int
^1da177e4c3f415 Linus Torvalds      2005-04-16  1002  nfs3_proc_lock(struct file *filp, int cmd, struct file_lock *fl)
^1da177e4c3f415 Linus Torvalds      2005-04-16  1003  {
496ad9aa8ef4480 Al Viro             2013-01-23  1004  	struct inode *inode = file_inode(filp);
f30cb757f680f96 Benjamin Coddington 2017-04-11  1005  	struct nfs_lock_context *l_ctx = NULL;
f30cb757f680f96 Benjamin Coddington 2017-04-11  1006  	struct nfs_open_context *ctx = nfs_file_open_context(filp);
f30cb757f680f96 Benjamin Coddington 2017-04-11  1007  	int status;
1093a60ef34bb12 Chuck Lever         2008-01-11  1008  
dd1fac6ae648cac Jeff Layton         2024-01-31 @1009  	if (fl->c.flc_flags & FL_CLOSE) {
f30cb757f680f96 Benjamin Coddington 2017-04-11  1010  		l_ctx = nfs_get_lock_context(ctx);
f30cb757f680f96 Benjamin Coddington 2017-04-11  1011  		if (IS_ERR(l_ctx))
f30cb757f680f96 Benjamin Coddington 2017-04-11  1012  			l_ctx = NULL;
f30cb757f680f96 Benjamin Coddington 2017-04-11  1013  		else
f30cb757f680f96 Benjamin Coddington 2017-04-11  1014  			set_bit(NFS_CONTEXT_UNLOCK, &ctx->flags);
f30cb757f680f96 Benjamin Coddington 2017-04-11  1015  	}
f30cb757f680f96 Benjamin Coddington 2017-04-11  1016  
f30cb757f680f96 Benjamin Coddington 2017-04-11  1017  	status = nlmclnt_proc(NFS_SERVER(inode)->nlm_host, cmd, fl, l_ctx);
f30cb757f680f96 Benjamin Coddington 2017-04-11  1018  
f30cb757f680f96 Benjamin Coddington 2017-04-11  1019  	if (l_ctx)
f30cb757f680f96 Benjamin Coddington 2017-04-11  1020  		nfs_put_lock_context(l_ctx);
f30cb757f680f96 Benjamin Coddington 2017-04-11  1021  
f30cb757f680f96 Benjamin Coddington 2017-04-11  1022  	return status;
^1da177e4c3f415 Linus Torvalds      2005-04-16  1023  }
^1da177e4c3f415 Linus Torvalds      2005-04-16  1024  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki