From: Christoph Hellwig <hch@lst.de>
To: Trond Myklebust <trondmy@kernel.org>, Anna Schumaker <anna@kernel.org>
Cc: Chris Mason <clm@meta.com>, linux-nfs@vger.kernel.org
Subject: delayed delegation return handling fix
Date: Wed, 28 Jan 2026 05:46:02 +0100 [thread overview]
Message-ID: <20260128044706.556046-1-hch@lst.de> (raw)
Hi all,
Chris Mason reported issues with the handling of delayed delegation
returns in the resent "add a LRU for delegations" series.
This series fixes that by not only doing the proper unlock, but also
by adding a new list dedicated to the delayed returned delegations.
Note that I could not trigger the delayed delegation handling naturally
and had to add crude error injection to force it.
Diffstat:
fs/nfs/client.c | 1
fs/nfs/delegation.c | 94 ++++++++++++++++++----------------------------
fs/nfs/delegation.h | 5 --
fs/nfs/nfs3proc.c | 3 -
fs/nfs/nfs4trace.h | 3 -
fs/nfs/proc.c | 3 -
include/linux/nfs_fs_sb.h | 2
include/linux/nfs_xdr.h | 2
8 files changed, 45 insertions(+), 68 deletions(-)
next reply other threads:[~2026-01-28 4:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 4:46 Christoph Hellwig [this message]
2026-01-28 4:46 ` [PATCH 1/7] NFS: return void from nfs4_inode_make_writeable Christoph Hellwig
2026-01-28 4:46 ` [PATCH 2/7] NFS: return void from ->return_delegation Christoph Hellwig
2026-01-28 4:46 ` [PATCH 3/7] NFS: use bool for the issync argument to nfs_end_delegation_return Christoph Hellwig
2026-01-28 4:46 ` [PATCH 4/7] NFS: remove the delegation == NULL check in nfs_end_delegation_return Christoph Hellwig
2026-01-28 4:46 ` [PATCH 5/7] NFS: fold nfs_abort_delegation_return into nfs_end_delegation_return Christoph Hellwig
2026-01-28 4:46 ` [PATCH 6/7] NFS: simplify error handling in nfs_end_delegation_return Christoph Hellwig
2026-01-28 4:46 ` [PATCH 7/7] NFS: fix delayed delegation return handling Christoph Hellwig
2026-01-28 19:15 ` delayed delegation return handling fix Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260128044706.556046-1-hch@lst.de \
--to=hch@lst.de \
--cc=anna@kernel.org \
--cc=clm@meta.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox