public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Steve Dickson <steved@redhat.com>
Cc: Ben Coddington <bcodding@hammerspace.com>,
	 Chuck Lever <chuck.lever@oracle.com>,
	linux-nfs@vger.kernel.org,  Jeff Layton <jlayton@kernel.org>
Subject: [PATCH nfs-utils v2 0/4] nfsdctl: properly handle older kernels that don't support min-threads
Date: Wed, 04 Feb 2026 11:48:21 -0500	[thread overview]
Message-ID: <20260204-minthreads-v2-0-a7eba34201e9@kernel.org> (raw)

Ben reported a problem with using new userland with old kernel. If he
tried to send down a setting that the kernel doesn't support, it returns
-EINVAL to the call.

This patch series adds a mechanism for nfsdctl to tell what attributes
are supported by the "threads" command. If can then use that to
determine whether to pass down the min-threads attribute or report an
error or warning.

This also removes the dependency on the UAPI headers by properly
maintaining the private nfsd_netlink.h file.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
Changes in v2:
- Add patch to unconditionally compile in min-threads support
- Make getpolicy_handler() return NL_SKIP
- Link to v1: https://lore.kernel.org/r/20260204-minthreads-v1-0-9f348608f884@kernel.org

---
Jeff Layton (4):
      nfsdctl: unconditionally enable support for min-threads
      nfsdctl: only resolve netlink family names once
      nfsdctl: query netlink policy before sending the minthreads attribute to kernel
      nfsdctl: remove unneeded newlines from xlog() format strings

 configure.ac                 |   6 +-
 utils/nfsdctl/nfsd_netlink.h |   2 +
 utils/nfsdctl/nfsdctl.c      | 204 ++++++++++++++++++++++++++++++++++---------
 3 files changed, 168 insertions(+), 44 deletions(-)
---
base-commit: 8f54511aefe1455161a6c4406ed8c770139f61e3
change-id: 20260203-minthreads-402ce87096e0

Best regards,
-- 
Jeff Layton <jlayton@kernel.org>


             reply	other threads:[~2026-02-04 16:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 16:48 Jeff Layton [this message]
2026-02-04 16:48 ` [PATCH nfs-utils v2 1/4] nfsdctl: unconditionally enable support for min-threads Jeff Layton
2026-02-04 16:48 ` [PATCH nfs-utils v2 2/4] nfsdctl: only resolve netlink family names once Jeff Layton
2026-02-04 16:48 ` [PATCH nfs-utils v2 3/4] nfsdctl: query netlink policy before sending the minthreads attribute to kernel Jeff Layton
2026-02-04 16:48 ` [PATCH nfs-utils v2 4/4] nfsdctl: remove unneeded newlines from xlog() format strings Jeff Layton
2026-02-18 14:19 ` [PATCH nfs-utils v2 0/4] nfsdctl: properly handle older kernels that don't support min-threads Jeff Layton
2026-02-18 17:26   ` Steve Dickson
2026-02-18 17:59 ` Benjamin Coddington
2026-02-23 15:19 ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260204-minthreads-v2-0-a7eba34201e9@kernel.org \
    --to=jlayton@kernel.org \
    --cc=bcodding@hammerspace.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox