From: Jeff Layton <jlayton@kernel.org>
To: Steve Dickson <steved@redhat.com>
Cc: Ben Coddington <bcodding@hammerspace.com>,
Chuck Lever <chuck.lever@oracle.com>,
linux-nfs@vger.kernel.org, Jeff Layton <jlayton@kernel.org>
Subject: [PATCH nfs-utils v2 4/4] nfsdctl: remove unneeded newlines from xlog() format strings
Date: Wed, 04 Feb 2026 11:48:25 -0500 [thread overview]
Message-ID: <20260204-minthreads-v2-4-a7eba34201e9@kernel.org> (raw)
In-Reply-To: <20260204-minthreads-v2-0-a7eba34201e9@kernel.org>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
utils/nfsdctl/nfsdctl.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/utils/nfsdctl/nfsdctl.c b/utils/nfsdctl/nfsdctl.c
index 4a3744a1c22e6beac7c039bded05fc087a121200..2b01f705874a4a3cad04042f6dfad22a66a7536f 100644
--- a/utils/nfsdctl/nfsdctl.c
+++ b/utils/nfsdctl/nfsdctl.c
@@ -1514,14 +1514,14 @@ static int lockd_config_doit(struct nl_sock *sock, int cmd, int grace, int tcppo
cb = nl_cb_alloc(NL_CB_CUSTOM);
if (!cb) {
- xlog(L_ERROR, "failed to allocate netlink callbacks\n");
+ xlog(L_ERROR, "failed to allocate netlink callbacks");
ret = 1;
goto out;
}
ret = nl_send_auto(sock, msg);
if (ret < 0) {
- xlog(L_ERROR, "send failed (%d)!\n", ret);
+ xlog(L_ERROR, "send failed (%d)!", ret);
goto out_cb;
}
@@ -1534,7 +1534,7 @@ static int lockd_config_doit(struct nl_sock *sock, int cmd, int grace, int tcppo
while (ret > 0)
nl_recvmsgs(sock, cb);
if (ret < 0) {
- xlog(L_ERROR, "Error: %s\n", strerror(-ret));
+ xlog(L_ERROR, "Error: %s", strerror(-ret));
ret = 1;
}
out_cb:
@@ -1554,7 +1554,7 @@ static int get_service(const char *svc)
ret = getaddrinfo(NULL, svc, &hints, &res);
if (ret) {
- xlog(L_ERROR, "getaddrinfo of \"%s\" failed: %s\n",
+ xlog(L_ERROR, "getaddrinfo of \"%s\" failed: %s",
svc, gai_strerror(ret));
return -1;
}
@@ -1575,7 +1575,7 @@ static int get_service(const char *svc)
}
break;
default:
- xlog(L_ERROR, "Bad address family: %d\n", res->ai_family);
+ xlog(L_ERROR, "Bad address family: %d", res->ai_family);
port = -1;
}
freeaddrinfo(res);
--
2.52.0
next prev parent reply other threads:[~2026-02-04 16:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 16:48 [PATCH nfs-utils v2 0/4] nfsdctl: properly handle older kernels that don't support min-threads Jeff Layton
2026-02-04 16:48 ` [PATCH nfs-utils v2 1/4] nfsdctl: unconditionally enable support for min-threads Jeff Layton
2026-02-04 16:48 ` [PATCH nfs-utils v2 2/4] nfsdctl: only resolve netlink family names once Jeff Layton
2026-02-04 16:48 ` [PATCH nfs-utils v2 3/4] nfsdctl: query netlink policy before sending the minthreads attribute to kernel Jeff Layton
2026-02-04 16:48 ` Jeff Layton [this message]
2026-02-18 14:19 ` [PATCH nfs-utils v2 0/4] nfsdctl: properly handle older kernels that don't support min-threads Jeff Layton
2026-02-18 17:26 ` Steve Dickson
2026-02-18 17:59 ` Benjamin Coddington
2026-02-23 15:19 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204-minthreads-v2-4-a7eba34201e9@kernel.org \
--to=jlayton@kernel.org \
--cc=bcodding@hammerspace.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox