public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <cel@kernel.org>
To: NeilBrown <neilb@ownmail.net>, Jeff Layton <jlayton@kernel.org>,
	Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: <linux-nfs@vger.kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v3 15/29] lockd: Use xdrgen XDR functions for the NLMv4 LOCK_RES procedure
Date: Tue, 17 Feb 2026 17:07:07 -0500	[thread overview]
Message-ID: <20260217220721.1928847-16-cel@kernel.org> (raw)
In-Reply-To: <20260217220721.1928847-1-cel@kernel.org>

From: Chuck Lever <chuck.lever@oracle.com>

Convert the LOCK_RES procedure to use xdrgen functions
nlm4_svc_decode_nlm4_res and nlm4_svc_encode_void.
LOCK_RES is a callback procedure where the client sends
lock results back to the server after an async LOCK
request.

The pc_argzero field is set to zero because xdrgen decoders
reliably initialize all arguments, making the early
defensive memset unnecessary.

This change also corrects the pc_xdrressize field, which
previously contained a placeholder value.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 fs/lockd/svc4proc.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/fs/lockd/svc4proc.c b/fs/lockd/svc4proc.c
index 6b391ec49341..c5f21fc2228c 100644
--- a/fs/lockd/svc4proc.c
+++ b/fs/lockd/svc4proc.c
@@ -1240,15 +1240,15 @@ static const struct svc_procedure nlm4svc_procedures[24] = {
 		.pc_xdrressize	= XDR_void,
 		.pc_name	= "TEST_RES",
 	},
-	[NLMPROC_LOCK_RES] = {
-		.pc_func = nlm4svc_proc_null,
-		.pc_decode = nlm4svc_decode_void,
-		.pc_encode = nlm4svc_encode_void,
-		.pc_argsize = sizeof(struct nlm_res),
-		.pc_argzero = sizeof(struct nlm_res),
-		.pc_ressize = sizeof(struct nlm_void),
-		.pc_xdrressize = St,
-		.pc_name = "LOCK_RES",
+	[NLMPROC4_LOCK_RES] = {
+		.pc_func	= nlm4svc_proc_null,
+		.pc_decode	= nlm4_svc_decode_nlm4_res,
+		.pc_encode	= nlm4_svc_encode_void,
+		.pc_argsize	= sizeof(struct nlm4_res),
+		.pc_argzero	= 0,
+		.pc_ressize	= 0,
+		.pc_xdrressize	= XDR_void,
+		.pc_name	= "LOCK_RES",
 	},
 	[NLMPROC_CANCEL_RES] = {
 		.pc_func = nlm4svc_proc_null,
-- 
2.53.0


  parent reply	other threads:[~2026-02-17 22:07 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-17 22:06 [PATCH v3 00/29] Convert lockd to use xdrgen for NLMv4 Chuck Lever
2026-02-17 22:06 ` [PATCH v3 01/29] Documentation: Add the RPC language description of NLM version 4 Chuck Lever
2026-02-17 22:06 ` [PATCH v3 02/29] lockd: Use xdrgen XDR functions for the NLMv4 NULL procedure Chuck Lever
2026-02-17 22:06 ` [PATCH v3 03/29] lockd: Use xdrgen XDR functions for the NLMv4 TEST procedure Chuck Lever
2026-02-17 22:06 ` [PATCH v3 04/29] lockd: Use xdrgen XDR functions for the NLMv4 LOCK procedure Chuck Lever
2026-02-17 22:06 ` [PATCH v3 05/29] lockd: Use xdrgen XDR functions for the NLMv4 CANCEL procedure Chuck Lever
2026-02-17 22:06 ` [PATCH v3 06/29] lockd: Use xdrgen XDR functions for the NLMv4 UNLOCK procedure Chuck Lever
2026-02-17 22:06 ` [PATCH v3 07/29] lockd: Use xdrgen XDR functions for the NLMv4 GRANTED procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 08/29] lockd: Refactor nlm4svc_callback() Chuck Lever
2026-02-17 22:07 ` [PATCH v3 09/29] lockd: Use xdrgen XDR functions for the NLMv4 TEST_MSG procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 10/29] lockd: Use xdrgen XDR functions for the NLMv4 LOCK_MSG procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 11/29] lockd: Use xdrgen XDR functions for the NLMv4 CANCEL_MSG procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 12/29] lockd: Use xdrgen XDR functions for the NLMv4 UNLOCK_MSG procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 13/29] lockd: Use xdrgen XDR functions for the NLMv4 GRANTED_MSG procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 14/29] lockd: Use xdrgen XDR functions for the NLMv4 TEST_RES procedure Chuck Lever
2026-02-17 22:07 ` Chuck Lever [this message]
2026-02-17 22:07 ` [PATCH v3 16/29] lockd: Use xdrgen XDR functions for the NLMv4 CANCEL_RES procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 17/29] lockd: Use xdrgen XDR functions for the NLMv4 UNLOCK_RES procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 18/29] lockd: Use xdrgen XDR functions for the NLMv4 GRANTED_RES procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 19/29] lockd: Use xdrgen XDR functions for the NLMv4 SM_NOTIFY procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 20/29] lockd: Convert server-side undefined procedures to xdrgen Chuck Lever
2026-02-17 22:07 ` [PATCH v3 21/29] lockd: Hoist file_lock init out of nlm4svc_decode_shareargs() Chuck Lever
2026-02-17 22:07 ` [PATCH v3 22/29] lockd: Prepare share helpers for xdrgen conversion Chuck Lever
2026-02-17 22:07 ` [PATCH v3 23/29] lockd: Use xdrgen XDR functions for the NLMv4 SHARE procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 24/29] lockd: Use xdrgen XDR functions for the NLMv4 UNSHARE procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 25/29] lockd: Use xdrgen XDR functions for the NLMv4 NM_LOCK procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 26/29] lockd: Use xdrgen XDR functions for the NLMv4 FREE_ALL procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 27/29] lockd: Add LOCKD_SHARE_SVID constant for DOS sharing mode Chuck Lever
2026-02-17 22:07 ` [PATCH v3 28/29] lockd: Remove C macros that are no longer used Chuck Lever
2026-02-17 22:07 ` [PATCH v3 29/29] lockd: Remove dead code from fs/lockd/xdr4.c Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260217220721.1928847-16-cel@kernel.org \
    --to=cel@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=dai.ngo@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@ownmail.net \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox