From: Chuck Lever <cel@kernel.org>
To: NeilBrown <neilb@ownmail.net>, Jeff Layton <jlayton@kernel.org>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: <linux-nfs@vger.kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v3 28/29] lockd: Remove C macros that are no longer used
Date: Tue, 17 Feb 2026 17:07:20 -0500 [thread overview]
Message-ID: <20260217220721.1928847-29-cel@kernel.org> (raw)
In-Reply-To: <20260217220721.1928847-1-cel@kernel.org>
From: Chuck Lever <chuck.lever@oracle.com>
The conversion of all NLMv4 procedures to xdrgen-generated
XDR functions is complete. The hand-rolled XDR size
calculation macros (Ck, No, St, Rg) and the nlm_void
structure definition served only the older implementations
and are now unused.
Also removes NLMDBG_FACILITY, which was set to the client
debug flag in server-side code but never referenced, and
corrects a comment to specify "NLMv4 Server procedures".
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
fs/lockd/svc4proc.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/fs/lockd/svc4proc.c b/fs/lockd/svc4proc.c
index ce340ea0d304..4044459b7c49 100644
--- a/fs/lockd/svc4proc.c
+++ b/fs/lockd/svc4proc.c
@@ -26,8 +26,6 @@
#include "nlm4xdr_gen.h"
#include "xdr4.h"
-#define NLMDBG_FACILITY NLMDBG_CLIENT
-
/*
* Wrapper structures combine xdrgen types with legacy nlm_lock.
* The xdrgen field must be first so the structure can be cast
@@ -1152,16 +1150,9 @@ static __be32 nlm4svc_proc_free_all(struct svc_rqst *rqstp)
/*
- * NLM Server procedures.
+ * NLMv4 Server procedures.
*/
-struct nlm_void { int dummy; };
-
-#define Ck (1+XDR_QUADLEN(NLM_MAXCOOKIELEN)) /* cookie */
-#define No (1+1024/4) /* netobj */
-#define St 1 /* status */
-#define Rg 4 /* range (offset + length) */
-
static const struct svc_procedure nlm4svc_procedures[24] = {
[NLMPROC4_NULL] = {
.pc_func = nlm4svc_proc_null,
--
2.53.0
next prev parent reply other threads:[~2026-02-17 22:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 22:06 [PATCH v3 00/29] Convert lockd to use xdrgen for NLMv4 Chuck Lever
2026-02-17 22:06 ` [PATCH v3 01/29] Documentation: Add the RPC language description of NLM version 4 Chuck Lever
2026-02-17 22:06 ` [PATCH v3 02/29] lockd: Use xdrgen XDR functions for the NLMv4 NULL procedure Chuck Lever
2026-02-17 22:06 ` [PATCH v3 03/29] lockd: Use xdrgen XDR functions for the NLMv4 TEST procedure Chuck Lever
2026-02-17 22:06 ` [PATCH v3 04/29] lockd: Use xdrgen XDR functions for the NLMv4 LOCK procedure Chuck Lever
2026-02-17 22:06 ` [PATCH v3 05/29] lockd: Use xdrgen XDR functions for the NLMv4 CANCEL procedure Chuck Lever
2026-02-17 22:06 ` [PATCH v3 06/29] lockd: Use xdrgen XDR functions for the NLMv4 UNLOCK procedure Chuck Lever
2026-02-17 22:06 ` [PATCH v3 07/29] lockd: Use xdrgen XDR functions for the NLMv4 GRANTED procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 08/29] lockd: Refactor nlm4svc_callback() Chuck Lever
2026-02-17 22:07 ` [PATCH v3 09/29] lockd: Use xdrgen XDR functions for the NLMv4 TEST_MSG procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 10/29] lockd: Use xdrgen XDR functions for the NLMv4 LOCK_MSG procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 11/29] lockd: Use xdrgen XDR functions for the NLMv4 CANCEL_MSG procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 12/29] lockd: Use xdrgen XDR functions for the NLMv4 UNLOCK_MSG procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 13/29] lockd: Use xdrgen XDR functions for the NLMv4 GRANTED_MSG procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 14/29] lockd: Use xdrgen XDR functions for the NLMv4 TEST_RES procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 15/29] lockd: Use xdrgen XDR functions for the NLMv4 LOCK_RES procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 16/29] lockd: Use xdrgen XDR functions for the NLMv4 CANCEL_RES procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 17/29] lockd: Use xdrgen XDR functions for the NLMv4 UNLOCK_RES procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 18/29] lockd: Use xdrgen XDR functions for the NLMv4 GRANTED_RES procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 19/29] lockd: Use xdrgen XDR functions for the NLMv4 SM_NOTIFY procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 20/29] lockd: Convert server-side undefined procedures to xdrgen Chuck Lever
2026-02-17 22:07 ` [PATCH v3 21/29] lockd: Hoist file_lock init out of nlm4svc_decode_shareargs() Chuck Lever
2026-02-17 22:07 ` [PATCH v3 22/29] lockd: Prepare share helpers for xdrgen conversion Chuck Lever
2026-02-17 22:07 ` [PATCH v3 23/29] lockd: Use xdrgen XDR functions for the NLMv4 SHARE procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 24/29] lockd: Use xdrgen XDR functions for the NLMv4 UNSHARE procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 25/29] lockd: Use xdrgen XDR functions for the NLMv4 NM_LOCK procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 26/29] lockd: Use xdrgen XDR functions for the NLMv4 FREE_ALL procedure Chuck Lever
2026-02-17 22:07 ` [PATCH v3 27/29] lockd: Add LOCKD_SHARE_SVID constant for DOS sharing mode Chuck Lever
2026-02-17 22:07 ` Chuck Lever [this message]
2026-02-17 22:07 ` [PATCH v3 29/29] lockd: Remove dead code from fs/lockd/xdr4.c Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260217220721.1928847-29-cel@kernel.org \
--to=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@ownmail.net \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox