From: Steve Dickson <steved@redhat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: [PATCH v2] Revert "nfsrahead: enable event-driven mountinfo monitoring"
Date: Fri, 6 Mar 2026 16:52:54 -0500 [thread overview]
Message-ID: <20260306215254.18764-1-steved@redhat.com> (raw)
This reverts commit 2b62ac4c273a647df07400dc1126fceb76ad96c0.
Most blktests block/ failed with "Timed out while waiting for
udev queue to empty." [1]
[1] https://lore.kernel.org/linux-block/CAHj4cs8URj2fJ7KyP9ViAm6npVOaMiAErnw2uFyPYEU2wb7G_w@mail.gmail.com/T/#t
---
tools/nfsrahead/main.c | 35 +----------------------------------
1 file changed, 1 insertion(+), 34 deletions(-)
diff --git a/tools/nfsrahead/main.c b/tools/nfsrahead/main.c
index 64953346..b7b889ff 100644
--- a/tools/nfsrahead/main.c
+++ b/tools/nfsrahead/main.c
@@ -16,7 +16,6 @@
#define CONF_NAME "nfsrahead"
#define NFS_DEFAULT_READAHEAD 128
-#define MNT_NM_TIMEOUT 10000
/* Device information from the system */
struct device_info {
@@ -118,39 +117,7 @@ out_free_device_info:
static int get_device_info(const char *device_number, struct device_info *device_info)
{
- int ret;
- struct libmnt_monitor *mn = NULL;
- int timeout_ms = MNT_NM_TIMEOUT;
-
- ret = get_mountinfo(device_number, device_info, MOUNTINFO_PATH);
- if (ret == 0)
- return 0;
-
- mn = mnt_new_monitor();
- if (!mn)
- goto fallback;
-
- if (mnt_monitor_enable_kernel(mn, 1) < 0) {
- mnt_unref_monitor(mn);
- goto fallback;
- }
-
- while (timeout_ms > 0) {
- int rc = mnt_monitor_wait(mn, timeout_ms);
- if (rc > 0) {
- ret = get_mountinfo(device_number, device_info, MOUNTINFO_PATH);
- if (ret == 0) {
- mnt_unref_monitor(mn);
- return 0;
- }
- } else {
- break;
- }
- }
- mnt_unref_monitor(mn);
- return ret;
-
-fallback:
+ int ret = get_mountinfo(device_number, device_info, MOUNTINFO_PATH);
for (int retry_count = 0; retry_count < 5 && ret != 0; retry_count++) {
usleep(50000);
ret = get_mountinfo(device_number, device_info, MOUNTINFO_PATH);
--
2.53.0
next reply other threads:[~2026-03-06 21:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 21:52 Steve Dickson [this message]
2026-03-06 22:10 ` [PATCH v2] Revert "nfsrahead: enable event-driven mountinfo monitoring" Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306215254.18764-1-steved@redhat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox