Re: [PATCH 0/2] nfsrahead: fix uninitialised memory crash and refine fast-path logging

Yi Zhang
2026-03-11T08:27:21Z

Hi Aaron

Verified the issue was fixed now with your patch, thanks.

Tested-by: Yi Zhang <yi.zhang@redhat.com>

On Mon, Mar 9, 2026 at 10:50 PM Aaron Tomlin <atomlin@atomlin.com> wrote:
>
> Hi Steve, Yi,
>
> This series addresses two issues stemming from the recent fast-path
> optimisation used to reject non-NFS block devices, which were caught during
> blktests.
>
> 1. [PATCH 1/2] fixes the glibc abort(3) by explicitly
> zero-initialising the device_info struct. This prevents the cleanup
> path from attempting to free uninitialised stack memory when the
> fast-path triggers an early exit.
>
> 2. [PATCH 2/2] updates the error handling in main() to log a
> descriptive debug message rather than a general error when a device
> is intentionally skipped, preventing misleading udev journal spam.
>
> Aaron Tomlin (2):
> nfsrahead: zero-initialise device_info struct
> nfsrahead: quieten misleading error for non-NFS block devices
>
> tools/nfsrahead/main.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> --
> 2.51.0
>

--
Best Regards,
Yi Zhang