Re: [PATCH v3 0/3] sunrpc/nfs: cleanup redundant debug checks and refactor macros

Andy Shevchenko
2026-03-20T12:08:38Z

On Thu, Mar 19, 2026 at 10:18:43PM +0800, Sean Chang wrote:
> This series cleans up redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards
> across sunrpc, nfsd, and lockd, as these checks are already handled
> within the dprintk macros.
>
> Additionally, it refactors the nfs_errorf() macros into a safer
> do-while(0) pattern and removes unused nfs_warnf() macros to improve
> code maintainability.

Shall we also revert the commit ebae102897e7 ("nfsd: Mark variable
__maybe_unused to avoid W=1 build break") as it seems related to
dprintk() issues?

--
With Best Regards,
Andy Shevchenko