Re: [PATCH v3 3/3] nfs: refactor nfs_errorf macros and remove unused ones

Andy Shevchenko
2026-03-19T14:41:32Z

On Thu, Mar 19, 2026 at 10:18:46PM +0800, Sean Chang wrote:
> refactor nfs_errorf() and nfs_ferrorf() to the standard do-while(0)
> pattern for safer macro expansion and kernel style compliance.
>
> additionally, remove nfs_warnf() and nfs_fwarnf() as git grep
> confirms they have no callers in the current tree.

...

> #define nfs_invalf(fc, fmt, ...) ((fc)->log.log ? \
> invalf(fc, fmt, ## __VA_ARGS__) : \

> invalf(fc, fmt, ## __VA_ARGS__) : \
> ({ dfprintk(fac, fmt "\n", ## __VA_ARGS__); -EINVAL; }))

Why not all of them?

--
With Best Regards,
Andy Shevchenko