From: Scott Mayhew <smayhew@redhat.com>
To: calum.mackay@oracle.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 4/5] pynfs: _testCbGetattr() should check the delegation that was received
Date: Fri, 3 Apr 2026 09:27:37 -0400 [thread overview]
Message-ID: <20260403132738.1482011-5-smayhew@redhat.com> (raw)
In-Reply-To: <20260403132738.1482011-1-smayhew@redhat.com>
It currently assumes that if it requested an attribute delegation, then
that's what it received. Better to actually check it instead.
Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
nfs4.1/server41tests/st_delegation.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/nfs4.1/server41tests/st_delegation.py b/nfs4.1/server41tests/st_delegation.py
index 6ed1f5d..2257966 100644
--- a/nfs4.1/server41tests/st_delegation.py
+++ b/nfs4.1/server41tests/st_delegation.py
@@ -351,6 +351,9 @@ def _testCbGetattr(t, env, change=0, size=0):
fh, stateid, deleg = __create_file_with_deleg(sess1, env.testname(t), openmask)
print("__create_file_with_deleg: ", fh, stateid, deleg)
+ delegtype = deleg.delegation_type
+ if delegtype != OPEN_DELEGATE_WRITE_ATTRS_DELEG and delegtype != OPEN_DELEGATE_WRITE:
+ fail("Didn't get a write delegation.")
attrs1 = do_getattrdict(sess1, fh, [FATTR4_CHANGE, FATTR4_SIZE,
FATTR4_TIME_ACCESS, FATTR4_TIME_MODIFY])
@@ -362,7 +365,7 @@ def _testCbGetattr(t, env, change=0, size=0):
if size > 0:
cbattrs[FATTR4_SIZE] = size
- if openmask & 1<<OPEN_ARGS_SHARE_ACCESS_WANT_DELEG_TIMESTAMPS:
+ if delegtype == OPEN_DELEGATE_WRITE_ATTRS_DELEG:
cbattrs[FATTR4_TIME_DELEG_ACCESS] = attrs1[FATTR4_TIME_ACCESS]
cbattrs[FATTR4_TIME_DELEG_MODIFY] = attrs1[FATTR4_TIME_MODIFY]
if change != 0:
--
2.53.0
next prev parent reply other threads:[~2026-04-03 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 13:27 [PATCH 0/5] pynfs: a handful of fixes and a new CB_GETATTR test Scott Mayhew
2026-04-03 13:27 ` [PATCH 1/5] pynfs: ensure tests clean up after themselves Scott Mayhew
2026-04-03 13:27 ` [PATCH 2/5] pynfs: fix the check for delegated attribute support Scott Mayhew
2026-04-03 13:27 ` [PATCH 3/5] pynfs: remove erroneous test from DELEG24 and DELEG25 Scott Mayhew
2026-04-03 14:07 ` Jeff Layton
2026-04-03 13:27 ` Scott Mayhew [this message]
2026-04-03 13:27 ` [PATCH 5/5] pynfs: add delegation test for CB_GETATTR after sync WRITE Scott Mayhew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260403132738.1482011-5-smayhew@redhat.com \
--to=smayhew@redhat.com \
--cc=calum.mackay@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox