Re: [PATCH] NFSD: Put cache get-reqs dump attrs under reply

Chuck Lever
2026-04-23T17:57:39Z

On 4/23/26 10:50 AM, Jeff Layton wrote:
> On Thu, 2026-04-23 at 13:26 -0400, Chuck Lever wrote:
>> On 4/23/26 10:24 AM, Thorsten Leemhuis wrote:
>>> On 4/23/26 19:17, Chuck Lever wrote:
>>>> From: Chuck Lever <chuck.lever@oracle.com>
>>>>
>>>> The new get-reqs dump operations added to sunrpc_cache.yaml and
>>>> nfsd.yaml place the "requests" nested attribute under dump.request.
>>>> A netlink dump carries an empty request; its payload travels back
>>>> in the reply. Because the spec names no reply attributes, the YNL
>>>> C code generator synthesizes a forward reference to a
>>>> <op>_rsp struct that is never defined, breaking any consumer of
>>>> these specs.
>>>>
>>>> This first surfaced when Thorsten Leemhuis built tools/net/ynl
>>>> against -next:
>>>
>>> Thx for the quick fix, this makes things work. In case anybody cares:
>>>
>>> Tested-by: Thorsten Leemhuis <linux@leemhuis.info>
>>
>> Thanks! Applied to nfsd-next.
>>
>>
>
> Many thanks! I was just sitting down to look at Thorsten's mail.

'Twas my own damn fault: it was a merge-resolution-gone-wrong.

--
Chuck Lever