From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b5-smtp.messagingengine.com (fout-b5-smtp.messagingengine.com [202.12.124.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 720D32D29C8 for ; Mon, 13 Jul 2026 06:22:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783923762; cv=none; b=gScYXeVSdPF+UwU/6RXunY10QUihZp8WU66S7HuOYNe9uIyCNFhhJS21P0yCf1XcaSn0XlAWN+EAfTbPtWdc3weLJlGHdwooBuLOCkCGwGkl7q+cl7h7dHjy/dOpZj/0+303Au+wU5HwaXpeEtq7VFYp1RzLUlMmTiH7wslsqrQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783923762; c=relaxed/simple; bh=zdoszbvaqb15HmyU3X8GvNrCk0s9HFGthNILWOCvqN0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NqAP0QYCliR28yW4r+Prt3QmgtSKrhQV2QYnZpaRfN3Do7D4Tcqb12JEjCSKC7BPd37Cvtg/qmdB1M2w7dpru2DlM+4UlmXpjZCOOmi0oA8NHQdN7gOVm1oq3H4Tg0tH5yCFpSyxcqu37W8AlxKFDDzAUFrSP2tzFYdebhxzaAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ownmail.net; spf=pass smtp.mailfrom=ownmail.net; dkim=pass (2048-bit key) header.d=ownmail.net header.i=@ownmail.net header.b=nN/0Anu9; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=RkLV9410; arc=none smtp.client-ip=202.12.124.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ownmail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ownmail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ownmail.net header.i=@ownmail.net header.b="nN/0Anu9"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="RkLV9410" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.stl.internal (Postfix) with ESMTP id 91FC01D00056; Mon, 13 Jul 2026 02:22:40 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Mon, 13 Jul 2026 02:22:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ownmail.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:subject:subject:to:to; s=fm2; t=1783923760; x=1784010160; bh=PoFRyznXthzskdT/+0xnQf+OqwzBjgQPvZ7okyFUP3s=; b= nN/0Anu9Xg1NiXGFP//rMut5+2DUlD3zSJ4bDfaiC7aCuEWlRQwKpl5XuUlLtpAZ ZepfaUHl+bFJHH8DvWndViYXzSgu8FJm/lkDMXZ+1z8lGLKwn8Ry9KCOD94Z2BbO UoQuN6WGr5otJS9CORpZTdDeiGNsTIQoorDz1J37a0zAEsXJhmOoRcKVqcmCUOSW MkVb+DI7dp1jim3z5dMIqtgmZq27v84qogCxGwn6ZlZdsM04G56GldkBWWcN9/kF EHRG8PIiaop/WdGUNxlx/zSab4q4Mwk6IpuUSNgNm0+DTgnRzv5H1u0ryIOfM/Z4 SufhlHr0jFVi8STquoIkyg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1783923760; x=1784010160; bh=P oFRyznXthzskdT/+0xnQf+OqwzBjgQPvZ7okyFUP3s=; b=RkLV9410jj4EQtbjW uZlqsZvkqEPCPMdsSo3HS1OEl29vnN218uafmp0ALJIiIJuWUS/7y+uAo5hlKhZw XZpHCoJe7w0zT/IsQxyvelxXiieV/iZ2Q/VXuHbMhAgyYj6cmZDYRSmz3vZHi0B/ jIWePzttGalyoa3FzM31LlNdteYssHCfNFcqssrp71WaOHiKY19So3xnxvZZZ4rr +YngaKFNxqRuFPdW+Vt+EVKE+38UdWGep4QivFNSdkm5xIF5ucVIIk/SFg08WiYY Jr5onvT0JhSvgk8WKy/iBHZKCjYUAexuuhXyTuKDmBYzzVrUin/6WnDapGkrfB6p lGYHw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGCQLlV7rkBD/d/I31+FnWtoJqihf/xdHHsD1TT1SXgkZmv6s4HWqyOhFnVY9n5MU BOJtfUQyVpUKpBykWA7VcVygcWfF57rWMRxVOWH1WLSaRWqIdVkOkFztYwGNBEJqYCGdER lIjYSwxT52xjXFVZpJf8rJpvaK2n+rZveXXBjrP8wYzN/FLD3xS33T1EHtom553cqC8fjn PrLIVOrVJtl+mjvVoS1EqhD6Dvk80GmCtdpbSpYdhpfrTqNe15e9hEbxs6wUV0rVyj4+GV nLsskUnL0p4PWJePiP27X7oGhT/Dg2xDgvflUJ5tmToCi4jiK9SzoT7k7idnqqIq2oUzNf 1fuohAV9HNT79WI/R8a+SzUyi7ZPbG0d+oMYOa3kob8xR+Z4gMT/1gSyZsidB6LLLdfAAj vQAJfuZkD6+mx9T4UqdtgoqVFGUCmDy1dJ+XKc0Xo8vYo4ao3QAy1c++4fpQ2gqXcCloRt JwBAzo7feRJdj/eqx/LfTQpauAhP1DrVQrDqXexpsGkOxxirEtp45IQ5gZ0BokwzCrwvIo +KVn/YZrw+tIAr5kyjWmJdXUuOeg1fBQ2GbpuSaTS4SygbdCQyM61pT+79nNJf2/NWMhFs +FH8zP6itmWV2g2xVT/+8TLO4BT99Q/qrn14y3f20QutGpWlo712wzXBRqZA X-ME-Proxy: Feedback-ID: i9d664b8f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 13 Jul 2026 02:22:38 -0400 (EDT) From: NeilBrown To: Chuck Lever , Jeff Layton Cc: Olga Kornievskaia , Dai Ngo , Tom Talpey , linux-nfs@vger.kernel.org Subject: [PATCH v3 01/17] nfsd: honour client-provided attributes for NFS4_CREATE_EXCLUSIVE4_1 Date: Mon, 13 Jul 2026 16:15:24 +1000 Message-ID: <20260713062219.6399-2-neilb@ownmail.net> X-Mailer: git-send-email 2.50.0.107.gf914562f5916.dirty In-Reply-To: <20260713062219.6399-1-neilb@ownmail.net> References: <20260713062219.6399-1-neilb@ownmail.net> Reply-To: NeilBrown Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: NeilBrown When a file is created with a v4.1 OPEN which requests NFS4_CREATE_EXCLUSIVE4_1, the request can include attributes to be set. However when the mtime/atime are set to hold the verifier, the other ia_valid flags are cleared, so no attributes requested by the client are used. This code was originally written for NFSv3 where NFS3_CREATE_EXCLUSIVE never includes attributes. When it was updated for v4.1, the fact that an exclusive create CAN include attributes was not handled properly. Fixes: ac6721a13e5b ("nfsd41: make sure nfs server process OPEN with EXCLUSIVE4_1 correctly") Reviewed-by: Jeff Layton Signed-off-by: NeilBrown --- fs/nfsd/nfs4proc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index 935408252ace..ca9460e97e2b 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -393,8 +393,8 @@ nfsd4_create_file(struct svc_rqst *rqstp, struct svc_fh *fhp, if ((iap->ia_valid & ATTR_SIZE) && (iap->ia_size == 0)) iap->ia_valid &= ~ATTR_SIZE; if (nfsd4_create_is_exclusive(open->op_createmode)) { - iap->ia_valid = ATTR_MTIME | ATTR_ATIME | - ATTR_MTIME_SET|ATTR_ATIME_SET; + iap->ia_valid |= ATTR_MTIME | ATTR_ATIME | + ATTR_MTIME_SET|ATTR_ATIME_SET; iap->ia_mtime.tv_sec = v_mtime; iap->ia_atime.tv_sec = v_atime; iap->ia_mtime.tv_nsec = 0; -- 2.50.0.107.gf914562f5916.dirty