From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <cel@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeff Layton <jlayton@kernel.org>
Subject: [PATCH 2/2] nfsd: fix nfserr type in nfsd_lookup_dentry()
Date: Mon, 03 Aug 2026 10:49:28 -0400 [thread overview]
Message-ID: <20260803-dir-deleg-v1-2-51be76861821@kernel.org> (raw)
In-Reply-To: <20260803-dir-deleg-v1-0-51be76861821@kernel.org>
Both nfsd_lookup_dentry() and nfsd_cross_mnt() return __be32.
Fixes: cf78c5a7d742 ("nfsd: move check_nfsd_access() call into nfsd_cross_mnt()")
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/nfsd/vfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index edb08c006a23..807e09521e0c 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -287,7 +287,7 @@ nfsd_lookup_dentry(struct svc_rqst *rqstp, struct svc_fh *fhp,
if (IS_ERR(dentry))
goto out_nfserr;
if (nfsd_mountpoint(dentry, exp)) {
- int nfserr = nfsd_cross_mnt(rqstp, &dentry, &exp);
+ __be32 nfserr = nfsd_cross_mnt(rqstp, &dentry, &exp);
if (nfserr) {
dput(dentry);
--
2.55.0
next prev parent reply other threads:[~2026-08-03 14:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 14:49 [PATCH 0/2] nfsd: fix up some sparse warnings Jeff Layton
2026-08-03 14:49 ` [PATCH 1/2] nfsd: fix type mismatch and explain host-endian xdr buffer usage Jeff Layton
2026-08-03 15:32 ` Chuck Lever
2026-08-03 15:43 ` Jeff Layton
2026-08-03 16:04 ` Chuck Lever
2026-08-03 16:23 ` Jeff Layton
2026-08-03 18:33 ` Chuck Lever
2026-08-03 18:58 ` Jeff Layton
2026-08-03 14:49 ` Jeff Layton [this message]
2026-08-03 15:16 ` [PATCH 2/2] nfsd: fix nfserr type in nfsd_lookup_dentry() Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260803-dir-deleg-v1-2-51be76861821@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=cel@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox