From: Chuck Lever <cel@kernel.org>
To: NeilBrown <neil@brown.name>, Jeff Layton <jlayton@kernel.org>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: <linux-nfs@vger.kernel.org>
Subject: [PATCH v1 00/10] New pragmas for the xdrgen tool
Date: Thu, 3 Sep 2026 11:03:41 -0400 [thread overview]
Message-ID: <20260903150351.9572-1-cel@kernel.org> (raw)
The NFSv2, NFSv3, and NFS_ACL conversions to xdrgen-generated codecs
need two important new features in the xdrgen tool to deal with a
few of the more complex structures that XDR can express.
The first is a payload that resides in the Linux page cache.
Currently the generated codec for a variable-length opaque copies
through a data pointer, but a READ result already sits in the pages
of rq_res and a WRITE payload arrives in the pages of the Receive
buffer. Marshaling and unmarshaling this type of payload needs to
avoid copying the payload's content.
The second is an array of non-scalar objects. Examples include the
NFS_ACL aclent<> list, which is the on-the-wire form of the kernel's
posix_acl, and the READDIR entry list, which is produced from a VFS
iteration.
No in-tree XDR specification applies either directive yet, so the
generated output remains unchanged across the whole series.
Chuck Lever (10):
SUNRPC: Carry a generated-codec context pointer in struct xdr_stream
SUNRPC: Bind the svc_rqst to its XDR streams
SUNRPC: Add svcxdr_encode_opaque_payload()
xdrgen: Pass the containing struct name to member codec emitters
xdrgen: Add a "pragma pages" directive
SUNRPC: Add svcxdr_decode_opaque_payload()
xdrgen: Extend the pages directive to page-resident arguments
xdrgen: Add hook-driven aggregate codec for variable-length arrays
xdrgen: Extend the aggregate codec to optional-data list members
xdrgen: Stream optional-data aggregate lists during encode
fs/nfsd/nfs4xdr.c | 1 +
include/linux/sunrpc/svc.h | 77 +++++
include/linux/sunrpc/xdr.h | 1 +
include/linux/sunrpc/xdrgen/_defs.h | 32 ++
net/sunrpc/xdr.c | 3 +
tools/net/sunrpc/xdrgen/README | 136 +++++++-
tools/net/sunrpc/xdrgen/generators/pointer.py | 68 +++-
tools/net/sunrpc/xdrgen/generators/struct.py | 197 +++++++++++-
tools/net/sunrpc/xdrgen/generators/union.py | 69 +++-
tools/net/sunrpc/xdrgen/grammars/xdr.lark | 2 +
.../C/pointer/decoder/pages_opaque.j2 | 6 +
.../C/pointer/definition/pages_opaque.j2 | 5 +
.../C/pointer/encoder/pages_opaque.j2 | 10 +
.../C/struct/declaration/aggregate_hooks.j2 | 14 +
.../C/struct/decoder/aggregate_array.j2 | 35 ++
.../C/struct/decoder/aggregate_optional.j2 | 31 ++
.../C/struct/decoder/pages_opaque.j2 | 6 +
.../C/struct/definition/pages_opaque.j2 | 5 +
.../C/struct/encoder/aggregate_array.j2 | 39 +++
.../C/struct/encoder/aggregate_optional.j2 | 29 ++
.../C/struct/encoder/pages_opaque.j2 | 10 +
.../templates/C/union/encoder/pages_opaque.j2 | 10 +
tools/net/sunrpc/xdrgen/xdr_ast.py | 300 ++++++++++++++++++
23 files changed, 1043 insertions(+), 43 deletions(-)
create mode 100644 tools/net/sunrpc/xdrgen/templates/C/pointer/decoder/pages_opaque.j2
create mode 100644 tools/net/sunrpc/xdrgen/templates/C/pointer/definition/pages_opaque.j2
create mode 100644 tools/net/sunrpc/xdrgen/templates/C/pointer/encoder/pages_opaque.j2
create mode 100644 tools/net/sunrpc/xdrgen/templates/C/struct/declaration/aggregate_hooks.j2
create mode 100644 tools/net/sunrpc/xdrgen/templates/C/struct/decoder/aggregate_array.j2
create mode 100644 tools/net/sunrpc/xdrgen/templates/C/struct/decoder/aggregate_optional.j2
create mode 100644 tools/net/sunrpc/xdrgen/templates/C/struct/decoder/pages_opaque.j2
create mode 100644 tools/net/sunrpc/xdrgen/templates/C/struct/definition/pages_opaque.j2
create mode 100644 tools/net/sunrpc/xdrgen/templates/C/struct/encoder/aggregate_array.j2
create mode 100644 tools/net/sunrpc/xdrgen/templates/C/struct/encoder/aggregate_optional.j2
create mode 100644 tools/net/sunrpc/xdrgen/templates/C/struct/encoder/pages_opaque.j2
create mode 100644 tools/net/sunrpc/xdrgen/templates/C/union/encoder/pages_opaque.j2
--
2.55.0
next reply other threads:[~2026-09-03 15:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 15:03 Chuck Lever [this message]
2026-09-03 15:03 ` [PATCH v1 01/10] SUNRPC: Carry a generated-codec context pointer in struct xdr_stream Chuck Lever
2026-09-03 15:03 ` [PATCH v1 02/10] SUNRPC: Bind the svc_rqst to its XDR streams Chuck Lever
2026-09-03 15:03 ` [PATCH v1 03/10] SUNRPC: Add svcxdr_encode_opaque_payload() Chuck Lever
2026-09-03 15:03 ` [PATCH v1 04/10] xdrgen: Pass the containing struct name to member codec emitters Chuck Lever
2026-09-03 15:03 ` [PATCH v1 05/10] xdrgen: Add a "pragma pages" directive Chuck Lever
2026-09-03 15:03 ` [PATCH v1 06/10] SUNRPC: Add svcxdr_decode_opaque_payload() Chuck Lever
2026-09-03 15:03 ` [PATCH v1 07/10] xdrgen: Extend the pages directive to page-resident arguments Chuck Lever
2026-09-03 15:03 ` [PATCH v1 08/10] xdrgen: Add hook-driven aggregate codec for variable-length arrays Chuck Lever
2026-09-03 15:03 ` [PATCH v1 09/10] xdrgen: Extend the aggregate codec to optional-data list members Chuck Lever
2026-09-03 15:03 ` [PATCH v1 10/10] xdrgen: Stream optional-data aggregate lists during encode Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903150351.9572-1-cel@kernel.org \
--to=cel@kernel.org \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox