Re: [RFC PATCH 1/2] common/nfs: add management helpers

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Sep 08, 2026 at 11:12:28PM -0700, Christoph Hellwig wrote:
> On Tue, Sep 08, 2026 at 07:22:26AM -0700, Darrick J. Wong wrote:
> > > +# Start rpcbind if it is not already running.
> > > +_start_rpcbind()
> > > +{
> > > +	rpcinfo -p localhost > /dev/null 2>&1 && return 0
> > > +	rpcbind 2>> $seqres.full || _notrun "Cannot start rpcbind"
> > > +	/usr/sbin/rpc.statd 2>> $seqres.full || _notrun "Cannot start rpc.statd"
> > > +	/usr/sbin/rpc.idmapd 2>> $seqres.full || _notrun "Cannot start rpc.idmapd"
> > > +	/usr/sbin/nfsdcld 2>> $seqres.full || _notrun "Cannot start nfsdcld"
> > 
> > Aren't these daemons usually configured as system services?
> > 
> > # service rpcbind start
> > 
> > etc?
> 
> They usually are, but doing that as part of a test feels wrong.
> Adding the relevant maintainers and list.

<nod> I guess for this test we actually want to launch our own nfs
daemons in a separate pid / network namespace so that they don't
interfere with nfs operations outside of the test (e.g. testing nfs
itself, nfsboot, etc)

> > 
> > > +}
> > > +
> > > +# Stop rpcbind.
> > > +_stop_rpcbind()
> > > +{
> > > +	pkill rpcbind 2>/dev/null
> > > +}
> > > +
> > > +# Start the NFS server if not already running.
> > > +_start_nfsd()
> > > +{
> > > +	rpcinfo -p localhost 2>/dev/null | grep -q nfs && return 0
> > > +	rpc.nfsd 2>> $seqres.full || _notrun "Cannot start rpc.nfsd"
> > > +	rpc.mountd 2>> $seqres.full || _notrun "Cannot start rpc.mountd"
> > > +}
> > > +
> > > +# Stop the NFS server.
> > > +_stop_nfsd()
> > > +{
> > > +	rpc.nfsd 0 2>/dev/null
> > > +	pkill rpc.mountd 2>/dev/null
> > 
> > If the system under test has nfs filesystems mounted, won't killing
> > those daemons also break the mounts?
> > 
> > I think that might break testing of nfs itself, and nfs-booted testing
> > nodes as well?
> 
> Possibly.  I guess if we want to save we need to launch a container
> or at least a network namespace this is bound too. 

Agreed, some isolation from the main system is necessary.

--D