From: Chuck Lever <cel@kernel.org>
To: Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: Rick Macklem <rmacklem@uoguelph.ca>,
linux-nfs@vger.kernel.org, Chuck Lever <cel@kernel.org>
Subject: [PATCH v5 06/11] NFSD: Record DRC population in lookup tracepoints
Date: Fri, 18 Sep 2026 13:21:18 -0400 [thread overview]
Message-ID: <20260918-duplicate-reply-cache-v5-6-b6aba9ebf2f4@kernel.org> (raw)
In-Reply-To: <20260918-duplicate-reply-cache-v5-0-b6aba9ebf2f4@kernel.org>
nfsd_drc_found reports the outcome of a lookup but not how full the
cache was at the time, so a trace cannot show whether retransmits are
being caught while the cache runs near its cap.
Assisted-by: LLM
Signed-off-by: Chuck Lever <cel@kernel.org>
---
fs/nfsd/nfscache.c | 4 +++-
fs/nfsd/trace.h | 11 +++++++----
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/fs/nfsd/nfscache.c b/fs/nfsd/nfscache.c
index 4d0101e93add..cd1011bd148d 100644
--- a/fs/nfsd/nfscache.c
+++ b/fs/nfsd/nfscache.c
@@ -487,6 +487,7 @@ int nfsd_cache_lookup(struct svc_rqst *rqstp, unsigned int start,
struct nfsd_drc_bucket *b;
int type = ntli->ntli_cachetype;
LIST_HEAD(dispose);
+ unsigned int entries;
int rtn = RC_DOIT;
if (type == RC_NOCACHE) {
@@ -556,7 +557,8 @@ int nfsd_cache_lookup(struct svc_rqst *rqstp, unsigned int start,
}
out_trace:
- trace_nfsd_drc_found(nn, rqstp, rtn);
+ entries = atomic_read(&nn->num_drc_entries);
+ trace_nfsd_drc_found(nn, entries, rqstp, rtn);
out_unlock:
spin_unlock(&b->cache_lock);
out:
diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h
index ed4efcfa3961..631682a76f9c 100644
--- a/fs/nfsd/trace.h
+++ b/fs/nfsd/trace.h
@@ -1513,23 +1513,26 @@ TRACE_DEFINE_ENUM(RC_DOIT);
TRACE_EVENT(nfsd_drc_found,
TP_PROTO(
const struct nfsd_net *nn,
+ unsigned int num_drc_entries,
const struct svc_rqst *rqstp,
int result
),
- TP_ARGS(nn, rqstp, result),
+ TP_ARGS(nn, num_drc_entries, rqstp, result),
TP_STRUCT__entry(
__field(unsigned long long, boot_time)
+ __field(unsigned int, num_drc_entries)
__field(unsigned long, result)
__field(u32, xid)
),
TP_fast_assign(
__entry->boot_time = nn->boot_time;
+ __entry->num_drc_entries = num_drc_entries;
__entry->result = result;
__entry->xid = be32_to_cpu(rqstp->rq_xid);
),
- TP_printk("boot_time=%16llx xid=0x%08x result=%s",
- __entry->boot_time, __entry->xid,
- show_drc_retval(__entry->result))
+ TP_printk("boot_time=%16llx entries=%u xid=0x%08x result=%s",
+ __entry->boot_time, __entry->num_drc_entries,
+ __entry->xid, show_drc_retval(__entry->result))
);
--
2.55.0
next prev parent reply other threads:[~2026-09-18 17:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 17:21 [PATCH v5 00/11] Improve the scalability of NFSD's classic DRC Chuck Lever
2026-09-18 17:21 ` [PATCH v5 01/11] NFSD: Remove hard cap on duplicate reply cache size Chuck Lever
2026-09-18 23:00 ` NeilBrown
2026-09-20 17:47 ` Chuck Lever
2026-09-20 22:10 ` NeilBrown
2026-09-18 17:21 ` [PATCH v5 02/11] SUNRPC: Assign a unique identifier to each svc_xprt Chuck Lever
2026-09-18 17:21 ` [PATCH v5 03/11] NFSD: Track transport in DRC entries Chuck Lever
2026-09-18 17:21 ` [PATCH v5 04/11] NFSD: Prepare bucket pruning for additional eviction reasons Chuck Lever
2026-09-18 17:21 ` [PATCH v5 05/11] NFSD: Add tracepoints for DRC entry eviction Chuck Lever
2026-09-18 17:21 ` Chuck Lever [this message]
2026-09-18 17:21 ` [PATCH v5 07/11] SUNRPC: Publish reply positions for upper-layer consumers Chuck Lever
2026-09-18 17:21 ` [PATCH v5 08/11] SUNRPC: Publish TCP reply positions Chuck Lever
2026-09-18 17:21 ` [PATCH v5 09/11] svcrdma: Publish RDMA " Chuck Lever
2026-09-18 17:21 ` [PATCH v5 10/11] NFSD: Evict acknowledged DRC entries Chuck Lever
2026-09-18 17:21 ` [PATCH v5 11/11] NFSD: Remove DRC checksum and payload_misses stat Chuck Lever
2026-09-18 23:39 ` NeilBrown
2026-09-19 16:11 ` Chuck Lever
2026-09-20 10:37 ` NeilBrown
2026-09-20 17:49 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918-duplicate-reply-cache-v5-6-b6aba9ebf2f4@kernel.org \
--to=cel@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=rmacklem@uoguelph.ca \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox