From: Christoph Hellwig <hch@lst.de>
To: daejun7.park@samsung.com
Cc: Carlos Maiolino <cem@kernel.org>,
linux-xfs@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
"Darrick J. Wong" <djwong@kernel.org>,
Dave Chinner <dgc@kernel.org>, Chuck Lever <cel@kernel.org>,
Jeff Layton <jlayton@kernel.org>, Dai Ngo <Dai.Ngo@oracle.com>,
Sergey Bashirov <sergeybashirov@gmail.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: make pNFS LAYOUTCOMMIT stable the way fdatasync does
Date: Tue, 13 Oct 2026 14:08:46 +0200 [thread overview]
Message-ID: <20261013120846.GA4040@lst.de> (raw)
In-Reply-To: <20261013-xfs-pnfs-commit-datasync-v1-1-2a12ef89ecd9@samsung.com>
On Tue, Oct 13, 2026 at 05:54:44PM +0900, Daejun Park via B4 Relay wrote:
> If preferred, I can factor the end of xfs_file_fsync() into a helper
> that both use, instead of exporting xfs_fsync_flush_log().
That feels like a bit of overkill, given that the shared code is
just two function calls.
> +int
> xfs_fsync_flush_log(
> struct xfs_inode *ip,
> bool datasync,
... but maybe this helper should move to xfs_log.c and renamed to
something like xfs_log_force_inode?
Otherwise this looks good, thanks a lot!
prev parent reply other threads:[~2026-10-13 12:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 8:54 [PATCH] xfs: make pNFS LAYOUTCOMMIT stable the way fdatasync does Daejun Park via B4 Relay
2026-10-13 12:08 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261013120846.GA4040@lst.de \
--to=hch@lst.de \
--cc=Dai.Ngo@oracle.com \
--cc=cel@kernel.org \
--cc=cem@kernel.org \
--cc=daejun7.park@samsung.com \
--cc=dgc@kernel.org \
--cc=djwong@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sergeybashirov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox