Linux NFS development
 help / color / mirror / Atom feed
From: VeroFess <coderzeng@gmail.com>
To: cel@kernel.org
Cc: Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
	Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-nfs@vger.kernel.org
Subject: Re: [PATCH 0/5] NFSD: Apply export security when a compound crosses exports
Date: Thu,  5 Nov 2026 04:32:13 +0800	[thread overview]
Message-ID: <20261104203213.1214721-1-coderzeng@gmail.com> (raw)
In-Reply-To: <20261103-verofess-2-v1-0-9e6568221beb@kernel.org>

Chuck,

I tested the five patches on an x86-64 KASAN guest. They applied in
order, the changed NFSD objects built with W=1, and the full bzImage
built with Btrfs, TLS, and NFSv4.2 inter-server COPY enabled.
The wire tests covered NFSv4.0, 4.1, and 4.2 where applicable.

After a reserved-port OPEN, high-port AUTH_SYS compounds that used
LOOKUP before READ, COPY, or CLONE stopped at LOOKUP with WRONGSEC.
The destination was unchanged. Direct PUTFH returned WRONGSEC, while
low-port COPY and CLONE succeeded. SECINFO and SECINFO_NO_NAME still
succeeded on the high port. READDIR with rdattr_error omitted the
protected filehandle.

After switching the source export to root_squash, LOOKUP; READ,
RESTOREFH; READ, and saved-source COPY/CLONE returned ACCESS with the
old OPEN stateid. The all_squash UID/GID cases and same-export
COPY/CLONE passed with the expected data.

With krb5 or krb5i on a krb5p export, OPEN by filehandle returned
WRONGSEC at PUTFH; OPEN by name returned it at OPEN. krb5p worked from
a high port and over TLS. NFSv3 LOOKUP returned PERM from a high port
and succeeded from a reserved port. I saw no KASAN report or oops in
the guest log.

Tested-by: VeroFess <coderzeng@gmail.com>

VeroFess

  parent reply	other threads:[~2026-11-04 20:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 19:52 [PATCH 0/5] NFSD: Apply export security when a compound crosses exports Chuck Lever
2026-11-03 19:52 ` [PATCH 1/5] NFSD: Check the secure-port policy when entering an export Chuck Lever
2026-11-03 19:52 ` [PATCH 2/5] NFSD: Defer the PUTFH secure-port check Chuck Lever
2026-11-03 19:52 ` [PATCH 3/5] NFSD: Report WRONGSEC from PUTFH when OPEN uses the current filehandle Chuck Lever
2026-11-03 19:52 ` [PATCH 4/5] NFSD: Apply the entered export's credentials after LOOKUP and RESTOREFH Chuck Lever
2026-11-03 19:52 ` [PATCH 5/5] NFSD: Use each export's credentials for the COPY and CLONE stateids Chuck Lever
2026-11-04 20:32 ` VeroFess [this message]
2026-11-04 21:06   ` [PATCH 0/5] NFSD: Apply export security when a compound crosses exports Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261104203213.1214721-1-coderzeng@gmail.com \
    --to=coderzeng@gmail.com \
    --cc=Dai.Ngo@oracle.com \
    --cc=cel@kernel.org \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox