From: Steve Dickson <SteveD@redhat.com>
To: NeilBrown <neilb@suse.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
libtirpc-devel@lists.sourceforge.net
Subject: Re: [Libtirpc-devel] [PATCH rpcbind] Fix path for rpcbind in rpcbind.service.
Date: Mon, 28 Nov 2016 15:42:45 -0500 [thread overview]
Message-ID: <21b59ce6-7657-14fa-949a-1cf9f82b6814@RedHat.com> (raw)
In-Reply-To: <87shqga40h.fsf@notabene.neil.brown.name>
On 11/24/2016 05:48 PM, NeilBrown wrote:
>
> Due to a miscommunication,
> Commit: 0cc39c519278 ("Provide systemd unit files for rpcbind")
> used sbindir as the location of rpcbind to put in the systemd unit
> file instead of bindir, which is where rpcbind gets installed.
>
> So change those few instances of sbindir to bindir so that the unit
> file will have the correct path.
>
> Signed-off-by: NeilBrown <neilb@suse.com>
Committed...
steved.
> ---
> configure.ac | 6 +++---
> systemd/rpcbind.service.in | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index acc69149c862..f34f669dc7da 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -61,9 +61,9 @@ AC_SEARCH_LIBS([pthread_create], [pthread])
>
> AC_CHECK_HEADERS([nss.h rpcsvc/mount.h])
>
> -# make sbindir available for substitution in config file
> +# make bindir available for substitution in config file
> # 2 "evals" needed to expand variable names
> -AC_SUBST([_sbindir])
> -AC_CONFIG_COMMANDS_PRE([eval eval _sbindir=$sbindir])
> +AC_SUBST([_bindir])
> +AC_CONFIG_COMMANDS_PRE([eval eval _bindir=$bindir])
>
> AC_OUTPUT([Makefile systemd/rpcbind.service])
> diff --git a/systemd/rpcbind.service.in b/systemd/rpcbind.service.in
> index c173b838bd42..e7e86da0c268 100644
> --- a/systemd/rpcbind.service.in
> +++ b/systemd/rpcbind.service.in
> @@ -11,7 +11,7 @@ After=rpcbind.socket
> [Service]
> Type=notify
> # distro can provide a drop-in adding EnvironmentFile=-/??? if needed.
> -ExecStart=@_sbindir@/rpcbind $RPCBIND_OPTIONS -w -f
> +ExecStart=@_bindir@/rpcbind $RPCBIND_OPTIONS -w -f
>
> [Install]
> WantedBy=multi-user.target
>
>
>
> ------------------------------------------------------------------------------
>
>
>
> _______________________________________________
> Libtirpc-devel mailing list
> Libtirpc-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/libtirpc-devel
>
prev parent reply other threads:[~2016-11-28 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 22:48 [PATCH rpcbind] Fix path for rpcbind in rpcbind.service NeilBrown
2016-11-28 20:42 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21b59ce6-7657-14fa-949a-1cf9f82b6814@RedHat.com \
--to=steved@redhat.com \
--cc=libtirpc-devel@lists.sourceforge.net \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).