From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: dhowells@redhat.com, akpm@linux-foundation.org,
jmorris@namei.org, shirishpargaonkar@gmail.com,
keyrings@linux-nfs.org, linux-nfs@vger.kernel.org,
linux-cifs@vger.kernel.org, Eric Paris <eparis@redhat.com>
Subject: Re: [PATCH] KEYS/DNS: Fix ____call_usermodehelper() to not lose the session keyring
Date: Fri, 17 Jun 2011 10:56:51 +0100 [thread overview]
Message-ID: <23040.1308304611@redhat.com> (raw)
In-Reply-To: <BANLkTimxJ5kHOODSPqRPcgbObjZbfT59uw@mail.gmail.com>
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> PS. Possibly it might make more sense to just put the "struct cred *"
> pointer into the "struct subprocess_info" and not change any of the
> function prototypes at all?
That's the way I did it originally, but someone thought doing it with an init
function was a better idea:-/
Your suggestion is slightly complicated by the capability restriction stuff
that caused the breakage. That needs to hack the creds at some point.
David
prev parent reply other threads:[~2011-06-17 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 23:56 [PATCH] KEYS/DNS: Fix ____call_usermodehelper() to not lose the session keyring David Howells
2011-06-17 0:26 ` Linus Torvalds
2011-06-17 9:56 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23040.1308304611@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=eparis@redhat.com \
--cc=jmorris@namei.org \
--cc=keyrings@linux-nfs.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=shirishpargaonkar@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).