public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <steved@redhat.com>
To: Zhuohao Bai <wcwfta@gmail.com>
Cc: libtirpc-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org,
	tanyuan@tinylab.org, forrestniu@foxmail.com, falcon@tinylab.org,
	zhuohao_bai@foxmail.com
Subject: Re: [PATCH v1 0/2] _rpc_dtablesize: decrease to fix excessive memory usage
Date: Fri, 5 Jan 2024 11:54:07 -0500	[thread overview]
Message-ID: <24d87eae-97e3-4839-aaa7-e058a3f66af5@redhat.com> (raw)
In-Reply-To: <cover.1698751763.git.zhuohao_bai@foxmail.com>



On 10/31/23 9:13 AM, Zhuohao Bai wrote:
> In the client code, the function _rpc_dtablesize() is used to determine the
> memory allocation for the __svc_xports array.
> 
> However, some operating systems (including the recent Manjaro OS) can have
> _SC_OPEN_MAX values as high as 1073741816, which can cause the __svc_xports
> array to become too large. This results in the process being killed.
> 
> There is a limit to the maximum number of files. To avoid this problem, a
> possible solution is to set the size to the lesser of 1024 and this value to
> ensure that the array space for open files is not too large, thus preventing
> the process from terminating.
> 
> Also discovered that some users have taken action on the issue. It is necessary
> to address this for all users. Ultimately, we determined that adjusting the
> size value of _rpc_dtablesize() and streamlining the existing user code would
> be the most effective solution.
> 
> 
> ---
> Changes in v1:
> Clean up the existing code in user
> 
> ---
> Links:
> RFC:https://lore.kernel.org/linux-nfs/tencent_E6816C9AF53E61BA5E0A313BBE5E1D19B00A@qq.com/T/#u
> 
> 
> Zhuohao Bai (2):
>    _rpc_dtablesize: Decrease the value of size.
>    _rpc_dtablesize: Cleaning up the existing code
> 
>   src/rpc_dtablesize.c | 2 ++
>   src/svc.c            | 2 --
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
Both Committed... (tag: libtirpc-1-3-5-rc2)

steved.


      parent reply	other threads:[~2024-01-05 16:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-31 13:13 [PATCH v1 0/2] _rpc_dtablesize: decrease to fix excessive memory usage Zhuohao Bai
2023-10-31 13:13 ` [PATCH v1 1/2] _rpc_dtablesize: Decrease the value of size Zhuohao Bai
2023-10-31 13:13 ` [PATCH v1 2/2] _rpc_dtablesize: Cleaning up the existing code Zhuohao Bai
2024-01-05 16:54 ` Steve Dickson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24d87eae-97e3-4839-aaa7-e058a3f66af5@redhat.com \
    --to=steved@redhat.com \
    --cc=falcon@tinylab.org \
    --cc=forrestniu@foxmail.com \
    --cc=libtirpc-devel@lists.sourceforge.net \
    --cc=linux-nfs@vger.kernel.org \
    --cc=tanyuan@tinylab.org \
    --cc=wcwfta@gmail.com \
    --cc=zhuohao_bai@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox