From: Jeff Layton <jlayton@kernel.org>
To: trondmy@kernel.org, linux-nfs@vger.kernel.org
Cc: Josef Bacik <josef@toxicpanda.com>,
Benjamin Coddington <bcodding@redhat.com>
Subject: Re: [PATCH v3 5/6] NFSv4: clp->cl_cons_state < 0 signifies an invalid nfs_client
Date: Tue, 25 Mar 2025 20:17:53 -0400 [thread overview]
Message-ID: <25e873a2e3dbd42255b24cae9fdb9ffcb41e5e67.camel@kernel.org> (raw)
In-Reply-To: <7059cac07b2bc3c6a249b66326a86a5858f74214.1742941932.git.trond.myklebust@hammerspace.com>
On Tue, 2025-03-25 at 18:35 -0400, trondmy@kernel.org wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
>
> If someone calls nfs_mark_client_ready(clp, status) with a negative
> value for status, then that should signal that the nfs_client is no
> longer valid.
>
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
> fs/nfs/nfs4state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
> index f1f7eaa97973..272d2ebdae0f 100644
> --- a/fs/nfs/nfs4state.c
> +++ b/fs/nfs/nfs4state.c
> @@ -1403,7 +1403,7 @@ int nfs4_schedule_stateid_recovery(const struct nfs_server *server, struct nfs4_
> dprintk("%s: scheduling stateid recovery for server %s\n", __func__,
> clp->cl_hostname);
> nfs4_schedule_state_manager(clp);
> - return 0;
> + return clp->cl_cons_state < 0 ? clp->cl_cons_state : 0;
> }
> EXPORT_SYMBOL_GPL(nfs4_schedule_stateid_recovery);
>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2025-03-26 0:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 22:35 [PATCH v3 0/6] Ensure that ENETUNREACH terminates state recovery trondmy
2025-03-25 22:35 ` [PATCH v3 1/6] SUNRPC: rpcbind should never reset the port to the value '0' trondmy
2025-03-26 10:43 ` Benjamin Coddington
2025-03-25 22:35 ` [PATCH v3 2/6] SUNRPC: rpc_clnt_set_transport() must not change the autobind setting trondmy
2025-03-26 10:43 ` Benjamin Coddington
2025-03-25 22:35 ` [PATCH v3 3/6] NFS: Shut down the nfs_client only after all the superblocks trondmy
2025-03-26 0:15 ` Jeff Layton
2025-03-26 0:37 ` Trond Myklebust
2025-03-26 10:07 ` Benjamin Coddington
2025-03-25 22:35 ` [PATCH v3 4/6] NFSv4: Further cleanups to shutdown loops trondmy
2025-03-26 0:17 ` Jeff Layton
2025-03-26 10:13 ` Jeff Layton
2025-03-26 10:46 ` Benjamin Coddington
2025-03-26 18:11 ` Trond Myklebust
2025-03-26 18:21 ` Jeff Layton
2025-03-26 18:24 ` Trond Myklebust
2025-03-27 0:35 ` Jeff Layton
2025-03-25 22:35 ` [PATCH v3 5/6] NFSv4: clp->cl_cons_state < 0 signifies an invalid nfs_client trondmy
2025-03-26 0:17 ` Jeff Layton [this message]
2025-03-26 10:46 ` Benjamin Coddington
2025-03-25 22:35 ` [PATCH v3 6/6] NFSv4: Treat ENETUNREACH errors as fatal for state recovery trondmy
2025-03-26 10:39 ` Benjamin Coddington
2025-03-26 11:18 ` Jeff Layton
2025-03-26 13:10 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25e873a2e3dbd42255b24cae9fdb9ffcb41e5e67.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=bcodding@redhat.com \
--cc=josef@toxicpanda.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox