From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AE2FECAAA1 for ; Sun, 30 Oct 2022 17:23:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229853AbiJ3RXT (ORCPT ); Sun, 30 Oct 2022 13:23:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbiJ3RXN (ORCPT ); Sun, 30 Oct 2022 13:23:13 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C102D62CB for ; Sun, 30 Oct 2022 10:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667150534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xy7b3nRtAL8M7+VedHsmmAKhtOAAl2XLancWVFWUXlg=; b=hI9pki9ehqyBbOGZhBEj74VX/iI+Z9qqD7or+YEFDZROvJMcLIG2dv4lHPdp1WmDeYleFx +vP/zmlOzvCmL/kKWamBf9LJAojFkR2P33Mzolc007HM6APawdvpzOyZL5Ih1O+6/s0itC qVli6IdXHDTPVE61DhYlHOCi6fH1mWQ= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-628-mzw1WJAnOWmDgCywHgT9oA-1; Sun, 30 Oct 2022 13:22:10 -0400 X-MC-Unique: mzw1WJAnOWmDgCywHgT9oA-1 Received: by mail-qt1-f199.google.com with SMTP id a19-20020a05622a02d300b0039a3711179dso6261061qtx.12 for ; Sun, 30 Oct 2022 10:22:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xy7b3nRtAL8M7+VedHsmmAKhtOAAl2XLancWVFWUXlg=; b=FFoSNy0ReCjddm0EuPyCGNCbgTVzvLw1MCG9vzOW78liFN9Lzg7HDJjb/Oz5jVPlLp WoQrvurmF2odB7/xPLzgzE6Q29PUyVhA2sfQTedNvdTKzKZNVG293TchV6ZV69tPp1nv RfzI1r0kW/VMNaZibQ0oVYQ9H7MH9Ofc5Y2tVVzl2qQ5jF7rnhI5e5h8Z4WYxPV3RAxN jj0AfbdxKusQmRWFZF9cZuXloQS9FzJ6V/DDo8/JxZhgEdyPSlOX/ZTZFWXn0r0bbJDA xlDsuzRL47WwnHfQu6hGuiloh7oUDvVG6Cb4hNmwuz30iZVyKVx9ZcKWQILlsLJi07ZL TuFg== X-Gm-Message-State: ACrzQf1KpXT0/gayYrIcLXyrlgqBYSe0OMKCpa7ye/KuLJDpPovutjKH 0Apn36GjP2qBjU1GCvnkxl2anqV2uFoQf1bI1huJBICx7kZE4omznVTjSZGD6GFIEbs3PDj9d7l Ows3mFHwa3irsHjNz0raq X-Received: by 2002:ac8:598b:0:b0:39d:9b6:69b3 with SMTP id e11-20020ac8598b000000b0039d09b669b3mr7692930qte.39.1667150529819; Sun, 30 Oct 2022 10:22:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5Dk+KkOvrrP3MpVWYtppipjk4B4K/I4Euc13541SOxoveysaouQDittrzMAvU/bssh9bNjNA== X-Received: by 2002:ac8:598b:0:b0:39d:9b6:69b3 with SMTP id e11-20020ac8598b000000b0039d09b669b3mr7692910qte.39.1667150529468; Sun, 30 Oct 2022 10:22:09 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-106-170.dyn.eolo.it. [146.241.106.170]) by smtp.gmail.com with ESMTPSA id s16-20020a05620a255000b006ee7923c187sm3213642qko.42.2022.10.30.10.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Oct 2022 10:22:08 -0700 (PDT) Message-ID: <27a6a587fee5e9172e41acd16ae1bc1f556fdbd7.camel@redhat.com> Subject: Re: [RFC][PATCH v2 19/31] timers: net: Use del_timer_shutdown() before freeing timer From: Paolo Abeni To: Jakub Kicinski , Steven Rostedt Cc: Linus Torvalds , linux-kernel@vger.kernel.org, Thomas Gleixner , Stephen Boyd , Guenter Roeck , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Mirko Lindner , Stephen Hemminger , Martin KaFai Lau , Alexei Starovoitov , Kuniyuki Iwashima , Pavel Begunkov , Menglong Dong , linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, bridge@lists.linux-foundation.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, lvs-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, tipc-discussion@lists.sourceforge.net Date: Sun, 30 Oct 2022 18:22:03 +0100 In-Reply-To: <20221028154617.3c63ba68@kernel.org> References: <20221027150525.753064657@goodmis.org> <20221027150928.780676863@goodmis.org> <20221027155513.60b211e2@gandalf.local.home> <20221027163453.383bbf8e@gandalf.local.home> <20221027170720.31497319@gandalf.local.home> <20221027183511.66b058c4@gandalf.local.home> <20221028183149.2882a29b@gandalf.local.home> <20221028154617.3c63ba68@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Fri, 2022-10-28 at 15:46 -0700, Jakub Kicinski wrote: > On Fri, 28 Oct 2022 18:31:49 -0400 Steven Rostedt wrote: > > Could someone from networking confirm (or deny) that the timer being > > removed in sk_stop_timer() will no longer be used even if del_timer() > > returns false? > > > > net/core/sock.c: > > > > void sk_stop_timer(struct sock *sk, struct timer_list* timer) > > { > > if (del_timer(timer)) > > __sock_put(sk); > > } > > > > If this is the case, then I'll add the following interface: > > > > del_timer_sync_shutdown() // the common case which syncs > > > > del_timer_shutdown() // the uncommon case, that returns immediately > > // used for those cases that add extra code to > > // handle it, like sk_stop_timer() > > Sorry too many bugs at once :) > > FWIW Paolo was saying privately earlier today that he spotted some cases > of reuse, he gave an example of ccid2_hc_tx_packet_recv() For the records, there are other cases, e.g. after sk_stop_timer() in clear_3rdack_retransmission() (mptcp code) the timer can be-rearmed without re-initializing. I *think* there are more of such use in the in ax25/rose code. > So we can't convert all cases of sk_stop_timer() in one fell swoop :( On the positive side, I think converting the sk_stop_timer in inet_csk_clear_xmit_timers() should be safe and should cover the issue reported by Guenter Cheers, Paolo