Re: [PATCH 1/1] NFSv4.1+ add trunking when server trunking detected

kernel test robot
2021-06-08T23:37:26Z

[-- Attachment #1: Type: text/plain, Size: 3354 bytes --]

Hi Olga,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on nfs/linux-next]
[also build test WARNING on v5.13-rc5 next-20210608]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Olga-Kornievskaia/NFSv4-1-add-trunking-when-server-trunking-detected/20210609-025208
base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: x86_64-randconfig-a015-20210608 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project d32cc150feb72f315a5bbd34f92e7beca21a50da)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/52d86dfa29146024beeca51af401aabbb329a942
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Olga-Kornievskaia/NFSv4-1-add-trunking-when-server-trunking-detected/20210609-025208
git checkout 52d86dfa29146024beeca51af401aabbb329a942
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> fs/nfs/nfs4client.c:369:20: warning: variable 'old_salen' set but not used [-Wunused-but-set-variable]
size_t clp_salen, old_salen;
^
1 warning generated.

vim +/old_salen +369 fs/nfs/nfs4client.c

363
364 static void nfs4_add_trunk(struct nfs_client *clp, struct nfs_client *old)
365 {
366 struct sockaddr_storage clp_addr, old_addr;
367 struct sockaddr *clp_sap = (struct sockaddr *)&clp_addr;
368 struct sockaddr *old_sap = (struct sockaddr *)&old_addr;
> 369 size_t clp_salen, old_salen;
370 struct xprt_create xprt_args = {
371 .ident = old->cl_proto,
372 .net = old->cl_net,
373 .servername = old->cl_hostname,
374 };
375 struct nfs4_add_xprt_data xprtdata = {
376 .clp = old,
377 };
378 struct rpc_add_xprt_test rpcdata = {
379 .add_xprt_test = old->cl_mvops->session_trunk,
380 .data = &xprtdata,
381 };
382
383 if (clp->cl_proto != old->cl_proto)
384 return;
385 clp_salen = rpc_peeraddr(clp->cl_rpcclient, clp_sap, sizeof(clp_addr));
386 old_salen = rpc_peeraddr(old->cl_rpcclient, old_sap, sizeof(old_addr));
387
388 if (clp_addr.ss_family != old_addr.ss_family)
389 return;
390
391 xprt_args.dstaddr = clp_sap;
392 xprt_args.addrlen = clp_salen;
393
394 xprtdata.cred = nfs4_get_clid_cred(old);
395 rpc_clnt_add_xprt(old->cl_rpcclient, &xprt_args,
396 rpc_clnt_setup_test_and_add_xprt, &rpcdata);
397
398 if (xprtdata.cred)
399 put_cred(xprtdata.cred);
400 }
401

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34438 bytes --]