From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E762C77B75 for ; Mon, 22 May 2023 21:08:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232267AbjEVVIA (ORCPT ); Mon, 22 May 2023 17:08:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231577AbjEVVH7 (ORCPT ); Mon, 22 May 2023 17:07:59 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 515FC9D for ; Mon, 22 May 2023 14:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684789630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fNX29lVhLrCaEtXMXBHbZSzlgt5OSgtHfMaigHYodOA=; b=Rj7D5MP6EYh98wS/6fNasafGmHLirJ6WgEyOxcUhk5iqkQyDjnOyROG/RkeJ/yDnbTU7/M SEey4/aO9PKzzwjgh54NRLcqSdnFn+CG8AKL7CulTiYXKjCykmeFo9Y+W8nXbo6rujNsy6 xaLQ4E3w6W3ByiMKVJwtLfQ6kBNNWcw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-609-5k7AXqqhNnilgNylUa_0gQ-1; Mon, 22 May 2023 17:07:05 -0400 X-MC-Unique: 5k7AXqqhNnilgNylUa_0gQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 64B84811E8D; Mon, 22 May 2023 21:07:05 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.39.192.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4CD0940CFD46; Mon, 22 May 2023 21:07:04 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <48886D84-1A04-4B07-A666-BB56684E759F@oracle.com> <380323.1681314997@warthog.procyon.org.uk> <1078650.1681394138@warthog.procyon.org.uk> <1235770.1681462057@warthog.procyon.org.uk> To: Herbert Xu Cc: dhowells@redhat.com, Chuck Lever III , Scott Mayhew , Ard Biesheuvel , Jeff Layton , Linux NFS Mailing List , "linux-crypto@vger.kernel.org" Subject: Re: Did the in-kernel Camellia or CMAC crypto implementation break? MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2892513.1684789623.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Mon, 22 May 2023 22:07:03 +0100 Message-ID: <2892515.1684789623@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Herbert Xu wrote: > > Actually, I was wondering about that. I see that all the testing data= seems > > to be statically loaded in testmgr.[ch], even if the algorithms to be = tested > > are resident in modules that aren't loaded yet (so it's kind of test "= on > > demand"). I guess it can't be split up amongst the algorithm modules = as some > > of the tests require stuff from multiple modules (eg. aes + cbs + cts)= . > = > Yes I've been meaning to split this up so they're colocated with > the generic implementation. I don't suppose you have anything to look at for this? Should I leave my testing stuff as it is for now until you've attempted this? David