From: cuigaosheng <cuigaosheng1@huawei.com>
To: Hariprasad Kelam <hkelam@marvell.com>
Cc: <trondmy@kernel.org>, <anna@kernel.org>, <chuck.lever@oracle.com>,
<jlayton@kernel.org>, <neilb@suse.de>, <kolga@netapp.com>,
<Dai.Ngo@oracle.com>, <tom@talpey.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<horms@kernel.org>, <linux-nfs@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH -next] gss_krb5: refactor code to return correct PTR_ERR in krb5_DK
Date: Fri, 12 Jul 2024 15:25:38 +0800 [thread overview]
Message-ID: <28e91219-6e53-f0e8-52f2-fab055ee3d70@huawei.com> (raw)
In-Reply-To: <ZpDWp9P6M+LUVcBZ@test-OptiPlex-Tower-Plus-7010>
yeah, thanks very much.
On 2024/7/12 15:09, Hariprasad Kelam wrote:
> On 2024-07-12 at 11:33:12, Gaosheng Cui (cuigaosheng1@huawei.com) wrote:
>> Refactor the code in krb5_DK to return PTR_ERR when an error occurs.
>>
>> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
>> ---
>> net/sunrpc/auth_gss/gss_krb5_keys.c | 8 ++++++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/sunrpc/auth_gss/gss_krb5_keys.c b/net/sunrpc/auth_gss/gss_krb5_keys.c
>> index 4eb19c3a54c7..b809e646329f 100644
>> --- a/net/sunrpc/auth_gss/gss_krb5_keys.c
>> +++ b/net/sunrpc/auth_gss/gss_krb5_keys.c
>> @@ -164,10 +164,14 @@ static int krb5_DK(const struct gss_krb5_enctype *gk5e,
>> goto err_return;
>>
>> cipher = crypto_alloc_sync_skcipher(gk5e->encrypt_name, 0, 0);
>> - if (IS_ERR(cipher))
>> + if (IS_ERR(cipher)) {
>> + ret = IS_ERR(cipher);
> need to use PTR_ERR?
>
> Thanks,
> Hariprasad k
>
>
> .
prev parent reply other threads:[~2024-07-12 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 6:03 [PATCH -next] gss_krb5: refactor code to return correct PTR_ERR in krb5_DK Gaosheng Cui
2024-07-12 7:09 ` Hariprasad Kelam
2024-07-12 7:25 ` cuigaosheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28e91219-6e53-f0e8-52f2-fab055ee3d70@huawei.com \
--to=cuigaosheng1@huawei.com \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=jlayton@kernel.org \
--cc=kolga@netapp.com \
--cc=kuba@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox