From: Henrique Martins <linux@martins.cc>
To: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/1] nfsd/exportfs: allow empty exports file
Date: Mon, 17 Nov 2014 07:53:36 -0800 [thread overview]
Message-ID: <29411.1416239616@monster.martins.cc> (raw)
In-Reply-To: <5469F395.9080701@RedHat.com>
steved> The presidence has been set that having an empty
steved> export file is not a problem. So I would rather
steved> change that xlog to be a L_WARNING and only log it
steved> when the verbose is set.
The situation, PRECEDENCE, when I got involved was:
no entries in exports:
nothing logged, nfsd started
all good entries in exports
nothing logged, nfsd started
mixture of bad and good entries in exports
bad entries logged, error logged, nfsd aborted
all bad entries in exports
bad entries logged, error logged, nfsd aborted
My first patch overlooked that first condition, and made the
situation like below, changed from PRECEDENCE uppercased:
no entries in exports:
EMPTY LOGGED, NFSD ABORTED
all good entries in exports
nothing logged, nfsd started
mixture of bad and good entries in exports
bad entries logged, NFSD STARTED
all bad entries in exports
bad entries logged, error logged, nfsd aborted
Current patch makes it, changes from PRECEDENCE uppercased:
no entries in exports:
nothing logged, nfsd started
all good entries in exports
nothing logged, nfsd started
mixture of bad and good entries in exports
bad entries logged, NFSD STARTED
all bad entries in exports
bad entries logged, error logged, nfsd aborted
Your patch makes it, changes from PRECEDENCE uppercased:
no entries in exports:
WARNING LOGGED, nfsd started
all good entries in exports
nothing logged, nfsd started
mixture of bad and good entries in exports
bad entries logged, NFSD STARTED
all bad entries in exports
bad entries logged, NFSD STARTED
Your pick,
-- Henrique
next prev parent reply other threads:[~2014-11-17 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 18:05 [PATCH 1/1] nfsd/exportfs: allow empty exports file Henrique Martins
2014-11-17 13:09 ` Steve Dickson
2014-11-17 15:53 ` Henrique Martins [this message]
2014-11-17 19:09 ` Steve Dickson
2014-11-17 20:27 ` Henrique Martins
2014-11-17 21:31 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29411.1416239616@monster.martins.cc \
--to=linux@martins.cc \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox