From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C58C4C7EE43 for ; Thu, 24 Aug 2023 14:27:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241612AbjHXO0f (ORCPT ); Thu, 24 Aug 2023 10:26:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241689AbjHXO0X (ORCPT ); Thu, 24 Aug 2023 10:26:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82B811BD4; Thu, 24 Aug 2023 07:26:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 213E661CD1; Thu, 24 Aug 2023 14:26:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95621C433C7; Thu, 24 Aug 2023 14:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692887177; bh=YMPIxCvyCLUmyZwI71t7N3ml0vkctUvAVh2phjfohoY=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=ZLlXNaqcZm0HjZA4DXwZu3vUcdBCPaMJSiBdwrZq0cbNEOnVdQai9ZxWfV09LNh0T bsO4Y6MWYGW/Nz7xb78W4yRfFJkeKgMJi9q8Uli2GwX8JrFMYzLonXEJAPEdRRD4Lt aS6DpdFrvB4CYUNUZmFDZ8epDER9zkfV6FddP6j47yWlfmM4Fn6fsAUgAeNjw0mVpN HGPfI/neyT+ZpUG/sBhJVT4r3mFn0IKBGQTynaVJ452GHU6lMnSkSthed7YzY0b24p CyLmUV0VxaABaEwN6NCUYE118gVSIeQVBa7nGfg9EyMyXA1sFQXKz00PK1OwF9hYQT QBkfuV/LFeG0w== Message-ID: <29dec29c4a776db82406f272557f97cebabca963.camel@kernel.org> Subject: Re: [linus:master] [NFSD] 39d432fc76: fsmark.files_per_sec -100.0% regression From: Jeff Layton To: Benjamin Coddington , Chuck Lever Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Date: Thu, 24 Aug 2023 10:26:15 -0400 In-Reply-To: References: <202308241229.68396422-oliver.sang@intel.com> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, 2023-08-24 at 10:12 -0400, Benjamin Coddington wrote: > On 24 Aug 2023, at 9:23, Chuck Lever wrote: >=20 > > On Thu, Aug 24, 2023 at 01:59:06PM +0800, kernel test robot wrote: > > >=20 > > >=20 > > > hi, Chuck Lever, > > >=20 > > > Fengwei (CCed) helped us review this astonishing finding by fsmark te= sts, > > > and doubt below part: > > > - nfsd4_end_grace(nn); > > > + trace_nfsd_end_grace(netns(file)); > > >=20 > > > and confirmed if adding back: > > > nfsd4_end_grace(nn); > > >=20 > > > the regression is gone and files_per_sec restore to 61.93. > >=20 > > As always, thanks for the report. However, this result is not > > plausible. "end_grace" happens only once after a server reboot. > >=20 > > Can you confirm that the NFS server kernel is not crashing > > during the test? >=20 > Does the removal of nfsd4_end_grace() here disable the ability of nfsdclt= rack to > terminate the grace period early on a first start of the server? >=20 >=20 Yes. That should be the only effect (which is why we didn't notice it). --=20 Jeff Layton