Re: WARNING at fs/nfs/write.c:743 nfs_inode_remove_request with -rc6

Will Deacon
2014-10-31T14:55:39Z

On Fri, Oct 31, 2014 at 02:49:13PM +0000, Weston Andros Adamson wrote:
> On Oct 20, 2014, at 9:57 AM, Will Deacon <will.deacon@arm.com> wrote:
> > On Sat, Oct 11, 2014 at 02:32:29PM +0100, Weston Andros Adamson wrote:
> >> I’ve been very busy, but I haven’t forgotten about your bug report!
> >
> > No problem, I've been busy too. I just checked with -rc1 and I can reproduce
> > the issue there too.
> >
> >> I think the WARN_ON_ONCE is just wrong, there are cases where the
> >> PG_INODE_REF flag is legitimately not set. The flag is set so that sub
> >> requests can mimmic the parent request’s reference count.
> >>
> >> Could you please run the reproducer again, unmount, then check the contents of
> >> /proc/fs/nfsfs/servers?
> >
> > Sure. I just tried this and that file is empty after unmounting.
>
> Sorry for the delay (again) - I just got back from a two week holiday.
>
> This is good news! I think we can safely remove this WARN_ON_ONCE and call it a
> day… or maybe calling it a month is more accurate ;)

Great! Feel free to add my reported-by/tested-by on that patch.

Will