* NFSv3 client hang on many simultanious reads
@ 2012-08-22 14:05 Dick Streefland, rnews
2012-08-23 10:45 ` Boaz Harrosh
0 siblings, 1 reply; 4+ messages in thread
From: Dick Streefland, rnews @ 2012-08-22 14:05 UTC (permalink / raw)
To: linux-nfs
I've encountered occasional NFS client lockups, and traced it down to
a situation where many simultanious processes are reading the same
directory tree. It is not very easy to reproduce, but when I run the
following script in an NFS-mounted directory containing a linux-3.5.2
kernel tree, I usually get a lockup after a few iterations:
#!/bin/sh
[ -d /tmp/linux-3.5.2 ] || cp -a linux-3.5.2 /tmp/
while true
do
date
for i in $(seq 30)
do
cp -au linux-3.5.2 /tmp/ &
echo -n .
done
echo
wait
done
When you run "top" in a separate window, you will initially see 30
"cp" processed competing for the CPU. After the lockup, the processes
disappear because their state becomes "D". Everything accessing the
mount points hangs at that moment. Killing all "cp" processes removes
the lockup. Mounts on other clients are unaffected.
The client kernel version is 3.4.7, but the problem also exists in 3.1
kernels. I cannot reproduce lockups with a 3.0 kernel. The server is
running Linux 3.1.4. The mount options from /proc/mounts are:
nfs-doc:/export/doc/ /doc nfs rw,relatime,vers=3,rsize=32768,wsize=32768,namlen=255,hard,proto=udp,timeo=11,retrans=3,sec=sys,mountaddr=172.17.8.66,mountvers=3,mountport=52214,mountproto=udp,local_lock=none,addr=172.17.8.66 0 0
The hanging processes are all sitting in "rpc_wait_bit_killable":
PID S WCHAN COMMAND
25547 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25548 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25549 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25550 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25551 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25552 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25553 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25554 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25555 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25556 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25557 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25558 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25559 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25560 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25561 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25562 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25563 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25564 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25565 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25566 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25567 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25568 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25569 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25570 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25571 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25572 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25573 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25574 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25575 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
25576 D rpc_wait_bit_killable cp -au linux-3.5.2 /tmp/
One "cp" process has this stack frame:
Aug 22 15:01:40 ivalo kernel: cp D ee9dbc04 0 25558 25315 0x00000000
Aug 22 15:01:40 ivalo kernel: ee9dbc5c 00000086 f7bfbef8 ee9dbc04 c1086c00 00000000 f7b8e280 c1c36280
Aug 22 15:01:40 ivalo kernel: f53dbcc0 00009be4 c1c36280 f7b8e280 f4dc26d0 ee9dbc10 cb104b78 00000001
Aug 22 15:01:40 ivalo kernel: cb1049c0 f469b22c 00000000 ee9dbc50 ee9dbc34 c1089907 00000001 ee9dbc40
Aug 22 15:01:40 ivalo kernel: Call Trace:
Aug 22 15:01:40 ivalo kernel: [<c1086c00>] ? __wake_up+0x40/0x50
Aug 22 15:01:40 ivalo kernel: [<c1089907>] ? get_parent_ip+0x27/0x40
Aug 22 15:01:40 ivalo kernel: [<c108995b>] ? sub_preempt_count.part.65+0x3b/0x80
Aug 22 15:01:40 ivalo kernel: [<c10899bf>] ? sub_preempt_count+0x1f/0x50
Aug 22 15:01:40 ivalo kernel: [<c1834f7d>] ? _raw_spin_unlock_irqrestore+0x1d/0x40
Aug 22 15:01:40 ivalo kernel: [<c183429e>] schedule+0x1e/0x50
Aug 22 15:01:40 ivalo kernel: [<c178efb9>] rpc_wait_bit_killable+0x19/0x30
Aug 22 15:01:40 ivalo kernel: [<c1832657>] __wait_on_bit+0x47/0x70
Aug 22 15:01:40 ivalo kernel: [<c178efa0>] ? rpc_release_task+0xb0/0xb0
Aug 22 15:01:40 ivalo kernel: [<c178efa0>] ? rpc_release_task+0xb0/0xb0
Aug 22 15:01:40 ivalo kernel: [<c18326dc>] out_of_line_wait_on_bit+0x5c/0x70
Aug 22 15:01:40 ivalo kernel: [<c107f740>] ? autoremove_wake_function+0x40/0x40
Aug 22 15:01:40 ivalo kernel: [<c178f78b>] __rpc_execute+0xdb/0x1a0
Aug 22 15:01:40 ivalo kernel: [<c178fa93>] rpc_execute+0x33/0x40
Aug 22 15:01:40 ivalo kernel: [<c1788824>] rpc_run_task+0x54/0x70
Aug 22 15:01:40 ivalo kernel: [<c1788917>] rpc_call_sync+0x37/0x60
Aug 22 15:01:40 ivalo kernel: [<c11d3e60>] nfs3_rpc_call.constprop.15+0x50/0x80
Aug 22 15:01:40 ivalo kernel: [<c11d4252>] nfs3_rpc+0x42/0x60
Aug 22 15:01:40 ivalo kernel: [<c11d447f>] nfs3_proc_getattr+0x3f/0x80
Aug 22 15:01:40 ivalo kernel: [<c11c5505>] __nfs_revalidate_inode+0x75/0x1f0
Aug 22 15:01:40 ivalo kernel: [<c11c570c>] ? nfs_revalidate_inode+0x1c/0x50
Aug 22 15:01:40 ivalo kernel: [<c11c00eb>] nfs_lookup_revalidate+0x1db/0x4a0
Aug 22 15:01:40 ivalo kernel: [<c11c1474>] ? nfs_permission+0x104/0x200
Aug 22 15:01:40 ivalo kernel: [<c1089907>] ? get_parent_ip+0x27/0x40
Aug 22 15:01:40 ivalo kernel: [<c108995b>] ? sub_preempt_count.part.65+0x3b/0x80
Aug 22 15:01:40 ivalo kernel: [<c10899bf>] ? sub_preempt_count+0x1f/0x50
Aug 22 15:01:40 ivalo kernel: [<c110b56d>] ? __d_lookup+0x8d/0x170
Aug 22 15:01:40 ivalo kernel: [<c1102266>] do_lookup+0x166/0x260
Aug 22 15:01:40 ivalo kernel: [<c1103ab5>] do_last.isra.43+0x115/0x5a0
Aug 22 15:01:40 ivalo kernel: [<c11040b5>] path_openat+0x95/0x320
Aug 22 15:01:40 ivalo kernel: [<c1100eb6>] ? getname_flags+0x26/0x120
Aug 22 15:01:40 ivalo kernel: [<c110442c>] do_filp_open+0x2c/0x80
Aug 22 15:01:40 ivalo kernel: [<c10899bf>] ? sub_preempt_count+0x1f/0x50
Aug 22 15:01:40 ivalo kernel: [<c1834f42>] ? _raw_spin_unlock+0x12/0x30
Aug 22 15:01:40 ivalo kernel: [<c110eef9>] ? alloc_fd+0xa9/0xf0
Aug 22 15:01:40 ivalo kernel: [<c1100f45>] ? getname_flags+0xb5/0x120
Aug 22 15:01:40 ivalo kernel: [<c10f6853>] do_sys_open+0xe3/0x1b0
Aug 22 15:01:40 ivalo kernel: [<c10f694d>] sys_open+0x2d/0x40
Aug 22 15:01:40 ivalo kernel: [<c1835b1c>] sysenter_do_call+0x12/0x2c
Aug 22 15:01:40 ivalo kernel: [<c1830000>] ? inet_sk_reselect_saddr+0x146/0x18a
All other "cp" processes have this stack frame:
Aug 22 15:01:40 ivalo kernel: cp D cb0ec180 0 25559 25315 0x00000000
Aug 22 15:01:40 ivalo kernel: ee8a7c5c 00000082 cb0ec0c0 cb0ec180 f63c7c60 cb0ec300 f7b8e280 c1c36280
Aug 22 15:01:40 ivalo kernel: f53d8d80 00009be4 c1c36280 f7b8e280 f56f7020 f63c7c60 f7b8fd78 ee8a7c6c
Aug 22 15:01:40 ivalo kernel: cb0ec300 f469b22c 00000000 ee8a7c50 ee8a7c34 c1089907 00000001 ee8a7c40
Aug 22 15:01:40 ivalo kernel: Call Trace:
Aug 22 15:01:40 ivalo kernel: [<c1089907>] ? get_parent_ip+0x27/0x40
Aug 22 15:01:40 ivalo kernel: [<c108995b>] ? sub_preempt_count.part.65+0x3b/0x80
Aug 22 15:01:40 ivalo kernel: [<c10899bf>] ? sub_preempt_count+0x1f/0x50
Aug 22 15:01:40 ivalo kernel: [<c1834f7d>] ? _raw_spin_unlock_irqrestore+0x1d/0x40
Aug 22 15:01:40 ivalo kernel: [<c183429e>] schedule+0x1e/0x50
Aug 22 15:01:40 ivalo kernel: [<c178efb9>] rpc_wait_bit_killable+0x19/0x30
Aug 22 15:01:40 ivalo kernel: [<c1832657>] __wait_on_bit+0x47/0x70
Aug 22 15:01:40 ivalo kernel: [<c178efa0>] ? rpc_release_task+0xb0/0xb0
Aug 22 15:01:40 ivalo kernel: [<c178efa0>] ? rpc_release_task+0xb0/0xb0
Aug 22 15:01:40 ivalo kernel: [<c18326dc>] out_of_line_wait_on_bit+0x5c/0x70
Aug 22 15:01:40 ivalo kernel: [<c107f740>] ? autoremove_wake_function+0x40/0x40
Aug 22 15:01:40 ivalo kernel: [<c178f78b>] __rpc_execute+0xdb/0x1a0
Aug 22 15:01:40 ivalo kernel: [<c178fa93>] rpc_execute+0x33/0x40
Aug 22 15:01:40 ivalo kernel: [<c1788824>] rpc_run_task+0x54/0x70
Aug 22 15:01:40 ivalo kernel: [<c1788917>] rpc_call_sync+0x37/0x60
Aug 22 15:01:40 ivalo kernel: [<c11d3e60>] nfs3_rpc_call.constprop.15+0x50/0x80
Aug 22 15:01:40 ivalo kernel: [<c11d4252>] nfs3_rpc+0x42/0x60
Aug 22 15:01:40 ivalo kernel: [<c11d447f>] nfs3_proc_getattr+0x3f/0x80
Aug 22 15:01:40 ivalo kernel: [<c11c5505>] __nfs_revalidate_inode+0x75/0x1f0
Aug 22 15:01:40 ivalo kernel: [<c11c570c>] ? nfs_revalidate_inode+0x1c/0x50
Aug 22 15:01:40 ivalo kernel: [<c11c00eb>] nfs_lookup_revalidate+0x1db/0x4a0
Aug 22 15:01:40 ivalo kernel: [<c11c1474>] ? nfs_permission+0x104/0x200
Aug 22 15:01:40 ivalo kernel: [<c1089907>] ? get_parent_ip+0x27/0x40
Aug 22 15:01:40 ivalo kernel: [<c108995b>] ? sub_preempt_count.part.65+0x3b/0x80
Aug 22 15:01:40 ivalo kernel: [<c10899bf>] ? sub_preempt_count+0x1f/0x50
Aug 22 15:01:40 ivalo kernel: [<c110b56d>] ? __d_lookup+0x8d/0x170
Aug 22 15:01:40 ivalo kernel: [<c1102266>] do_lookup+0x166/0x260
Aug 22 15:01:40 ivalo kernel: [<c1103ab5>] do_last.isra.43+0x115/0x5a0
Aug 22 15:01:40 ivalo kernel: [<c11040b5>] path_openat+0x95/0x320
Aug 22 15:01:40 ivalo kernel: [<c1100eb6>] ? getname_flags+0x26/0x120
Aug 22 15:01:40 ivalo kernel: [<c110442c>] do_filp_open+0x2c/0x80
Aug 22 15:01:40 ivalo kernel: [<c10899bf>] ? sub_preempt_count+0x1f/0x50
Aug 22 15:01:40 ivalo kernel: [<c1834f42>] ? _raw_spin_unlock+0x12/0x30
Aug 22 15:01:40 ivalo kernel: [<c110eef9>] ? alloc_fd+0xa9/0xf0
Aug 22 15:01:40 ivalo kernel: [<c1100f45>] ? getname_flags+0xb5/0x120
Aug 22 15:01:40 ivalo kernel: [<c10f6853>] do_sys_open+0xe3/0x1b0
Aug 22 15:01:40 ivalo kernel: [<c10f694d>] sys_open+0x2d/0x40
Aug 22 15:01:40 ivalo kernel: [<c1835b1c>] sysenter_do_call+0x12/0x2c
--
Dick
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: NFSv3 client hang on many simultanious reads
2012-08-22 14:05 NFSv3 client hang on many simultanious reads Dick Streefland, rnews
@ 2012-08-23 10:45 ` Boaz Harrosh
2012-08-23 20:04 ` Dick Streefland, rnews
0 siblings, 1 reply; 4+ messages in thread
From: Boaz Harrosh @ 2012-08-23 10:45 UTC (permalink / raw)
To: Dick Streefland; +Cc: rnews, linux-nfs
On 08/22/2012 05:05 PM, Dick Streefland wrote:
<>
>
> The client kernel version is 3.4.7, but the problem also exists in 3.1
> kernels. I cannot reproduce lockups with a 3.0 kernel. The server is
> running Linux 3.1.4. The mount options from /proc/mounts are:
>
It seems from above that the problem was introduced between 3.0
and 3.1.
Would it be at all possible for you to do a "git bisect" between
3.0 and 3.1 to Identify the bad commit that introduced this problem?
Thanks in advance
Boaz
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: NFSv3 client hang on many simultanious reads
2012-08-23 10:45 ` Boaz Harrosh
@ 2012-08-23 20:04 ` Dick Streefland, rnews
2012-08-29 12:11 ` Dick Streefland, rnews
0 siblings, 1 reply; 4+ messages in thread
From: Dick Streefland, rnews @ 2012-08-23 20:04 UTC (permalink / raw)
To: linux-nfs
Boaz Harrosh <bharrosh@panasas.com> wrote:
| It seems from above that the problem was introduced between 3.0
| and 3.1.
|
| Would it be at all possible for you to do a "git bisect" between
| 3.0 and 3.1 to Identify the bad commit that introduced this problem?
It took a little while, in part because of a false positive, but here
is the bisect result:
43cedbf0e8dfb9c5610eb7985d5f21263e313802 is the first bad commit
commit 43cedbf0e8dfb9c5610eb7985d5f21263e313802
Author: Trond Myklebust <Trond.Myklebust@netapp.com>
Date: Sun Jul 17 16:01:03 2011 -0400
SUNRPC: Ensure that we grab the XPRT_LOCK before calling xprt_alloc_slot
This throttles the allocation of new slots when the socket is busy
reconnecting and/or is out of buffer space.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
:040000 040000 7d1ad2865000b8cb85d4d458137d88ba2894dbdc 726403505c0518b5275ff7d1bb0d21fdb1817461 M include
:040000 040000 d8f92df1985a24e91217d09efd3f775768af0eab b1c251877291dffcbd2826506e956f722f14ff86 M net
Could this chunk cause a deadlock?
@@ -1001,10 +1004,25 @@ void xprt_reserve(struct rpc_task *task)
{
struct rpc_xprt *xprt = task->tk_xprt;
+ task->tk_status = 0;
+ if (task->tk_rqstp != NULL)
+ return;
+
+ /* Note: grabbing the xprt_lock_write() here is not strictly needed,
+ * but ensures that we throttle new slot allocation if the transport
+ * is congested (e.g. if reconnecting or if we're out of socket
+ * write buffer space).
+ */
+ task->tk_timeout = 0;
+ task->tk_status = -EAGAIN;
+ if (!xprt_lock_write(xprt, task))
+ return;
+
task->tk_status = -EIO;
spin_lock(&xprt->reserve_lock);
xprt_alloc_slot(task);
spin_unlock(&xprt->reserve_lock);
+ xprt_release_write(xprt, task);
}
--
Dick
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: NFSv3 client hang on many simultanious reads
2012-08-23 20:04 ` Dick Streefland, rnews
@ 2012-08-29 12:11 ` Dick Streefland, rnews
0 siblings, 0 replies; 4+ messages in thread
From: Dick Streefland, rnews @ 2012-08-29 12:11 UTC (permalink / raw)
To: linux-nfs
dick.streefland@altium.nl (Dick Streefland) wrote:
| Could this chunk cause a deadlock?
|
| @@ -1001,10 +1004,25 @@ void xprt_reserve(struct rpc_task *task)
| {
| struct rpc_xprt *xprt = task->tk_xprt;
|
| + task->tk_status = 0;
| + if (task->tk_rqstp != NULL)
| + return;
| +
| + /* Note: grabbing the xprt_lock_write() here is not strictly needed,
| + * but ensures that we throttle new slot allocation if the transport
| + * is congested (e.g. if reconnecting or if we're out of socket
| + * write buffer space).
| + */
| + task->tk_timeout = 0;
| + task->tk_status = -EAGAIN;
| + if (!xprt_lock_write(xprt, task))
| + return;
| +
| task->tk_status = -EIO;
| spin_lock(&xprt->reserve_lock);
| xprt_alloc_slot(task);
| spin_unlock(&xprt->reserve_lock);
| + xprt_release_write(xprt, task);
| }
I doublechecked, and this chunk does indeed cause the hang.
According to the comment, the lock is not strictly needed.
So how about simply reverting this?
--
Dick
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-29 12:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-22 14:05 NFSv3 client hang on many simultanious reads Dick Streefland, rnews
2012-08-23 10:45 ` Boaz Harrosh
2012-08-23 20:04 ` Dick Streefland, rnews
2012-08-29 12:11 ` Dick Streefland, rnews
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).