From: David Howells <dhowells@redhat.com>
To: Olof Johansson <olof@lixom.net>
Cc: dhowells@redhat.com, Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NFS: Don't use debug-printk-only local variables
Date: Thu, 26 Sep 2013 13:39:03 +0100 [thread overview]
Message-ID: <3222.1380199143@warthog.procyon.org.uk> (raw)
In-Reply-To: <1380175008-13090-1-git-send-email-olof@lixom.net>
Olof Johansson <olof@lixom.net> wrote:
> - struct nfs_inode *nfsi = NFS_I(page->mapping->host);
> struct fscache_cookie *cookie = nfs_i_fscache(page->mapping->host);
>
> BUG_ON(!cookie);
> dfprintk(FSCACHE, "NFS: fscache releasepage (0x%p/0x%p/0x%p)\n",
> - cookie, page, nfsi);
> + cookie, page, NFS_I(page->mapping->host));
This is really the wrong fix. The null dfprintk() should use no_printk().
David
next prev parent reply other threads:[~2013-09-26 12:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 15:09 [RFC][PATCH 0/3] FS-Cache: NFS(/CIFS/Ceph/9P): Fix start-caching whilst writing race David Howells
2013-09-20 15:09 ` [PATCH 1/3] FS-Cache: Add use/unuse/wake cookie wrappers David Howells
2013-09-20 15:09 ` [PATCH 2/3] FS-Cache: Provide the ability to enable/disable cookies David Howells
2013-09-20 15:09 ` [PATCH 3/3] NFS: Use i_writecount to control whether to get an fscache cookie in nfs_open() David Howells
2013-09-26 5:56 ` [PATCH] NFS: Don't use debug-printk-only local variables Olof Johansson
2013-09-26 11:24 ` David Howells
2013-09-26 12:39 ` David Howells [this message]
2013-09-23 17:00 ` [RFC][PATCH 0/3] FS-Cache: NFS(/CIFS/Ceph/9P): Fix start-caching whilst writing race Milosz Tanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3222.1380199143@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).