Linux NFS development
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <cel@kernel.org>, linux-nfs@vger.kernel.org
Cc: Chuck Lever <chuck.lever@oracle.com>,
	David Howells <dhowells@redhat.com>
Subject: Re: [PATCH RFC 0/4] Send RPC-on-TCP with one sock_sendmsg() call
Date: Fri, 14 Jul 2023 09:26:03 -0400	[thread overview]
Message-ID: <3376204b7b0335721956c45f22b10a2ff41aa276.camel@kernel.org> (raw)
In-Reply-To: <168893265677.1949.1632048925203798962.stgit@manet.1015granger.net>

On Sun, 2023-07-09 at 16:04 -0400, Chuck Lever wrote:
> After some discussion with David Howells at LSF/MM 2023, we arrived
> at a plan to use a single sock_sendmsg() call for transmitting an
> RPC message on socket-based transports. This is an initial part of
> the transition to support handling folios with file content, but it
> has scalability benefits as well.
> 
> Comments, suggestions, and test results are welcome.
> 
> ---
> 
> Chuck Lever (4):
>       SUNRPC: Convert svc_tcp_sendmsg to use bio_vecs directly
>       SUNRPC: Convert svc_udp_sendto() to use the per-socket bio_vec array
>       SUNRPC: Use a per-transport receive bio_vec array
>       SUNRPC: Send RPC message on TCP with a single sock_sendmsg() call
> 
> 
>  include/linux/sunrpc/svc.h     |   1 -
>  include/linux/sunrpc/svcsock.h |   7 ++
>  net/sunrpc/svcsock.c           | 142 ++++++++++++++++++---------------
>  3 files changed, 86 insertions(+), 64 deletions(-)
> 
> --
> Chuck Lever
> 

Aside from my concerns with bounds checking on the first patch, this
looks like a good set of changes overall. Does it show any performance
improvements in your testing?
-- 
Jeff Layton <jlayton@kernel.org>

  parent reply	other threads:[~2023-07-14 13:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-09 20:04 [PATCH RFC 0/4] Send RPC-on-TCP with one sock_sendmsg() call Chuck Lever
2023-07-09 20:04 ` [PATCH RFC 1/4] SUNRPC: Convert svc_tcp_sendmsg to use bio_vecs directly Chuck Lever
2023-07-14 13:12   ` Jeff Layton
2023-07-09 20:05 ` [PATCH RFC 2/4] SUNRPC: Convert svc_udp_sendto() to use the per-socket bio_vec array Chuck Lever
2023-07-09 20:05 ` [PATCH RFC 3/4] SUNRPC: Use a per-transport receive " Chuck Lever
2023-07-09 20:05 ` [PATCH RFC 4/4] SUNRPC: Send RPC message on TCP with a single sock_sendmsg() call Chuck Lever
2023-07-14 13:26 ` Jeff Layton [this message]
2023-07-14 13:44   ` [PATCH RFC 0/4] Send RPC-on-TCP with one " Chuck Lever III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3376204b7b0335721956c45f22b10a2ff41aa276.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=cel@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=dhowells@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox