From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1 1/3] SUNRPC: Remove unused svc_rqst::rq_lock field
Date: Mon, 17 Oct 2022 08:55:33 -0400 [thread overview]
Message-ID: <355a0d843130bad8fc743b19fec2b829aed6b326.camel@kernel.org> (raw)
In-Reply-To: <166593521604.1710.10648202421284171508.stgit@klimt.1015granger.net>
On Sun, 2022-10-16 at 11:46 -0400, Chuck Lever wrote:
> Clean up after commit 22700f3c6df5 ("SUNRPC: Improve ordering of
> transport processing").
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> include/linux/sunrpc/svc.h | 1 -
> net/sunrpc/svc.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
> index daecb009c05b..3b59eb9cf884 100644
> --- a/include/linux/sunrpc/svc.h
> +++ b/include/linux/sunrpc/svc.h
> @@ -311,7 +311,6 @@ struct svc_rqst {
> struct auth_domain * rq_gssclient; /* "gss/"-style peer info */
> struct svc_cacherep * rq_cacherep; /* cache info */
> struct task_struct *rq_task; /* service thread */
> - spinlock_t rq_lock; /* per-request lock */
> struct net *rq_bc_net; /* pointer to backchannel's
> * net namespace
> */
> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
> index 7c9a0d0b1230..d2bb1d04c524 100644
> --- a/net/sunrpc/svc.c
> +++ b/net/sunrpc/svc.c
> @@ -638,7 +638,6 @@ svc_rqst_alloc(struct svc_serv *serv, struct svc_pool *pool, int node)
> return rqstp;
>
> __set_bit(RQ_BUSY, &rqstp->rq_flags);
> - spin_lock_init(&rqstp->rq_lock);
> rqstp->rq_server = serv;
> rqstp->rq_pool = pool;
>
>
>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2022-10-17 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 15:46 [PATCH 1 1/3] SUNRPC: Remove unused svc_rqst::rq_lock field Chuck Lever
2022-10-16 15:47 ` [PATCH 1 2/3] NFSD: Finish converting the NFSv2 GETACL result encoder Chuck Lever
2022-10-17 13:02 ` Jeff Layton
2022-10-16 15:47 ` [PATCH 1 3/3] NFSD: Finish converting the NFSv3 " Chuck Lever
2022-10-17 13:04 ` Jeff Layton
2022-10-17 12:55 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=355a0d843130bad8fc743b19fec2b829aed6b326.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox