Re: [PATCH] nfsd: move init of percpu reply_cache_stats counters back to nfsd_init_net

Thorsten Leemhuis
2023-06-18T14:02:50Z

On 18.06.23 14:09, Jeff Layton wrote:
> On Sun, 2023-06-18 at 12:40 +0200, Thorsten Leemhuis wrote:
>> On 16.06.23 22:54, Jeff Layton wrote:
>>> On Fri, 2023-06-16 at 16:27 -0400, Chuck Lever wrote:
>>
>> FWIW, might be worth to simply tell Linus about it and let him decide,
>> that's totally fine and even documented in the old and the new docs for
>> handling regressions[1].
>>
>> [1]
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/Documentation/process/handling-regressions.rst?id=eed892da9cd08be76a8f467c600ef58716dbb4d2
>
> I'd rather Chuck make the final call here.

Totally fine for me, I just wanted to remind folks that this option
exist, as I got the impression people forget it or fear it might annoy
Linux. :D

>>>>> Cc: stable@vger.kernel.org # v6.3+
>>>>> Fixes: f5f9d4a314da ("nfsd: move reply cache initialization into nfsd startup")
>>>> Why both Fixes: and Cc: stable?
>>> *shrug* : they mean different things. I can drop the Cc stable.
>>
>> Please leave it, only a stable tag ensures backporting; a fixes tag
>> alone is not enough. See [1] above or these recent messages from Greg:
>>
>> https://lore.kernel.org/all/2023061137-algorithm-almanac-1337@gregkh/
>> https://lore.kernel.org/all/2023060703-colony-shakily-3514@gregkh/
>
> Chuck and I also recently requested that the stable series not pick
> patches automatically for fs/nfsd. This does need to be backported
> though, so I cc'ed stable to make that clear.

Great, many thx! Ciao, thorsten