From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 712563E2749 for ; Mon, 23 Mar 2026 20:14:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774296885; cv=none; b=W+BAp1yca+GdXERaRF7f7zWIIrMdoXtQpeBYoIBwYIRlM+ntwfLCRxXbg1Apz+v7TqmXUnMBTafTiMMnu0XiLCryWo3RtIGeqiRKNdF1bEhllcf7oGsaXqIemPyC2u7FV6ZWL6ZWYE3MhRAP4vYn8YvZulmhMhp9eMStgUiBeFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774296885; c=relaxed/simple; bh=CLdnA3HKaQpw2E+DK6Es/dEh/73c0GMWs6hlZ0iX8Cw=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=cUKvT48f3WUgSB8I/zD+TlTPpH7+aHfNQwnQtnN3BA+7bc5cp6oeHh+wCw5x2P53IiCNzhm/s86V/E4dfU0KvFJxiJarxVbAxyQZsqMmZr0nbxvpj1yTkznoVcN1oGfnnNXU2PdGqx5iqg204CAD6PH2Cctlfu7F5N62Cjibx9c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BuggZgv6; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BuggZgv6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774296883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DYa0tTMe+fh3t2cBObuxsAe/E5w0S9HN28FrVDi7GMQ=; b=BuggZgv6lVbSmu2us7iDrqx1n7ua1kicOKTeQQDRg/BHmwo1aVjKxbhElgZIRr8zcxBlvm Igpvi8hOXwInj+x0FFuaOhBi0ygWYtxU6yiatuQJI7oEAN8plf8pfvtTy0q5bQ/6jTEbzX jAATd0jcsrujHROQ3F/kVT+KkjcWwHY= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-279-abKn93TAPU2bn-bvqjtKYQ-1; Mon, 23 Mar 2026 16:14:35 -0400 X-MC-Unique: abKn93TAPU2bn-bvqjtKYQ-1 X-Mimecast-MFC-AGG-ID: abKn93TAPU2bn-bvqjtKYQ_1774296873 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 62D281955D57; Mon, 23 Mar 2026 20:14:31 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.44.33.121]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 79DED19560B1; Mon, 23 Mar 2026 20:14:23 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <2d8ce118-2f7a-4b7f-8786-4581b29cb74e@chenxiaosong.com> References: <2d8ce118-2f7a-4b7f-8786-4581b29cb74e@chenxiaosong.com> <20260304140328.112636-1-dhowells@redhat.com> <20260304140328.112636-18-dhowells@redhat.com> To: ChenXiaoSong Cc: dhowells@redhat.com, Matthew Wilcox , Christoph Hellwig , Jens Axboe , Leon Romanovsky , Steve French , Christian Brauner , Paulo Alcantara , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Paulo Alcantara Subject: Re: [RFC PATCH 17/17] netfs: Combine prepare and issue ops and grab the buffers on request Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3574142.1774296862.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Mon, 23 Mar 2026 20:14:22 +0000 Message-ID: <3574143.1774296862@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 ChenXiaoSong wrote: > I reviewed this patch in your repository's netfs-next branch (it looks > slightly different from the version posted to the mailing list) and foun= d two > issues, the following additional changes are needed: Thanks! I've been testing the patches further and cleaning them up. I wi= ll hopefully post them again soon. David